Uh oh!
There was an error while loading. Please reload this page.
doc: remove AsyncWrap mentions from async_hooks.md - #33249
Closed
puzpuzpuz wants to merge 1 commit into
Closed
Conversation
AsyncWrap is a private API and should not be mentioned in the documentation.
addaleax
approved these changes
May 5, 2020
targos
approved these changes
May 6, 2020
legendecas
approved these changes
May 6, 2020
Flarna
approved these changes
May 6, 2020
benjamingr
approved these changes
May 6, 2020
jasnell
approved these changes
May 6, 2020
addaleax
commented
May 7, 2020
Member
Landed in dab51dd |
addaleax pushed a commit
that referenced
this pull request
May 7, 2020
AsyncWrap is a private API and should not be mentioned in the documentation. PR-URL: #33249 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere pushed a commit
that referenced
this pull request
May 11, 2020
AsyncWrap is a private API and should not be mentioned in the documentation. PR-URL: #33249 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
codebytere pushed a commit
that referenced
this pull request
Jun 7, 2020
AsyncWrap is a private API and should not be mentioned in the documentation. PR-URL: #33249 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AsyncWrap is a private API and should not be mentioned in the documentation. For some reasons, it was there for ages.
cc @nodejs/async_hooks
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes