test: add Symbol test for assert.deepEqual()

[Trott]

The existing test never ran because typeof Symbol === 'function' and not
'symbol'. Update to Symbol() which will be a symbol and not a function.

[Trott]

CI: https://ci.nodejs.org/job/node-test-pull-request/484/

[evanlucas]

I would think we should maybe even go as far as adding tests for things like:

assert.throws(function() {
assert.deepEqual(Symbol('a'), Symbol('a'));
});
assert.deepEqual(Symbol.for('a'), Symbol.for('a'));

What are your thoughts on that?

[Trott]

@evanlucas I think your first example is handled in this test addition over at #3124. However, that PR very possibly may never land, so let's put a pin in that for sure....

The second example you give, oh yes!

[vkurchatkin]

It would be nice to have code coverage to catch such things

[jasnell]

LGTM

[Trott]

@evanlucas On the one hand, #3124 got closed, so that suggests adding the tests you proposed separately. On the other hand, TSC agreed this week to lock Assert so any tests added would presumably only document existing behavior. So... ¯\_(ツ)_/¯

[Trott]

Landed in 0f99320

[MylesBorins]

If we are going to be backporting tests for LTS this should probably be tagged

[Trott]

Would the right tag be land-on-v4.x?

[MylesBorins]

I believe so /cc @jasnell

[MylesBorins]

Got an update.

lts-watch-v4x if the decision hasn't been made yet

[Trott]

OK, tagged. Leave it closed, reopen it, or doesn't matter either way?

[jasnell]

Doesn't matter either way (open or closed)

On Fri, Oct 16, 2015 at 2:45 PM, Rich Trott notifications@github.com
wrote:

OK, tagged. Leave it closed, reopen it, or doesn't matter either way?

—
Reply to this email directly or view it on GitHub
#3327 (comment).

[jasnell]

Landed in v4.x-staging in 6305d26