Uh oh!
There was an error while loading. Please reload this page.
benchmark: fixing http_server_for_chunky_client.js - #33271
Closed
edsadr wants to merge 1 commit into
Closed
Conversation
edsadr
commented
May 8, 2020
ContributorAuthor
ping @nodejs/benchmarking |
BridgeAR
commented
May 14, 2020
Member
@nodejs/http @nodejs/http2 PTAL |
nodejs-github-bot
commented
May 19, 2020
Collaborator
Collaborator
jasnell
approved these changes
May 22, 2020
BridgeAR
approved these changes
May 23, 2020
BridgeAR pushed a commit
to BridgeAR/node
that referenced
this pull request
May 23, 2020
PR-URL: nodejs#33271 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR
commented
May 23, 2020
Member
Landed in 6af15eb 🎉 |
codebytere pushed a commit
that referenced
this pull request
Jun 18, 2020
PR-URL: #33271 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
codebytere pushed a commit
that referenced
this pull request
Jun 18, 2020
PR-URL: #33271 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
codebytere pushed a commit
that referenced
this pull request
Jun 30, 2020
PR-URL: #33271 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
codebytere pushed a commit
that referenced
this pull request
Jul 8, 2020
PR-URL: #33271 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a broken benchmark due to the http header's size restriction introduced earlier
make -j4 test(UNIX), orvcbuild test(Windows) passes