Skip to content

test: add hr-time Web platform tests - #33287

Closed
targos wants to merge 1 commit into
nodejs:masterfrom
targos:wpt-hr-time
Closed

test: add hr-time Web platform tests#33287
targos wants to merge 1 commit into
nodejs:masterfrom
targos:wpt-hr-time

Conversation

@targos

@targostargos commented May 7, 2020

Copy link
Copy Markdown
Member

Refs: #32790

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label May 7, 2020
cjihrig
cjihrig approved these changes May 7, 2020
View reviewed changes

@cjihrigcjihrig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubberstamp LGTM

@nodejs-github-bot

nodejs-github-bot commented May 8, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31239/

targos added a commit that referenced this pull request May 10, 2020
@targos
test: add hr-time Web platform tests
c252f6c
Refs: #32790
PR-URL: #33287
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@targos

targos commented May 10, 2020

Copy link
Copy Markdown
MemberAuthor

Landed in c252f6c

@targostargos closed this May 10, 2020
@targos
targos deleted the wpt-hr-time branch May 10, 2020 11:56
codebytere pushed a commit that referenced this pull request May 11, 2020
@targos@codebytere
test: add hr-time Web platform tests
1d2c81f
Refs: #32790
PR-URL: #33287
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@codebyterecodebytere mentioned this pull request May 18, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 7, 2020
@targos@codebytere
test: add hr-time Web platform tests
cd92052
Refs: #32790
PR-URL: #33287
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@codebyterecodebytere mentioned this pull request Jun 9, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@cjihrigcjihrigcjihrig approved these changes
@joyeecheungjoyeecheungjoyeecheung approved these changes

Assignees

No one assigned

Labels

testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@targos@nodejs-github-bot@jasnell@cjihrig@joyeecheung