Skip to content

src: add promise_resolve to SetupHooks comment - #33365

Closed
danbev wants to merge 1 commit into
nodejs:masterfrom
danbev:async_wrap.cc-typo
Closed

src: add promise_resolve to SetupHooks comment#33365
danbev wants to merge 1 commit into
nodejs:masterfrom
danbev:async_wrap.cc-typo

Conversation

@danbev

@danbevdanbev commented May 12, 2020

Copy link
Copy Markdown
Contributor

This commit adds promise_resolve to the list of callbacks mentioned in
the comment. It also fixes a minor typo, every -> ever.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label May 12, 2020
@nodejs-github-bot

nodejs-github-bot commented May 13, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31305/

@danbev
src: add promise_resolve to SetupHooks comment
b885766
This commit adds promise_resolve to the list of callbacks mentioned in
the comment. It also fixes a minor typo, every -> ever.
@danbev
danbevforce-pushed the async_wrap.cc-typo branch from 9bf9465 to b885766CompareMay 15, 2020 04:12
@nodejs-github-bot

nodejs-github-bot commented May 15, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31342/

danbev added a commit that referenced this pull request May 18, 2020
@danbev
src: add promise_resolve to SetupHooks comment
b477ac8
This commit adds promise_resolve to the list of callbacks mentioned in
the comment. It also fixes a minor typo, every -> ever.
PR-URL: #33365
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danbev

danbev commented May 18, 2020

Copy link
Copy Markdown
ContributorAuthor

Landed in b477ac8.

@danbevdanbev closed this May 18, 2020
@danbev
danbev deleted the async_wrap.cc-typo branch May 18, 2020 04:17
codebytere pushed a commit that referenced this pull request May 21, 2020
@danbev@codebytere
src: add promise_resolve to SetupHooks comment
499600c
This commit adds promise_resolve to the list of callbacks mentioned in
the comment. It also fixes a minor typo, every -> ever.
PR-URL: #33365
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere pushed a commit that referenced this pull request Jun 7, 2020
@danbev@codebytere
src: add promise_resolve to SetupHooks comment
975d2c5
This commit adds promise_resolve to the list of callbacks mentioned in
the comment. It also fixes a minor typo, every -> ever.
PR-URL: #33365
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere pushed a commit to codebytere/node that referenced this pull request Jun 9, 2020
@danbev@codebytere
src: add promise_resolve to SetupHooks comment
9883ba6
This commit adds promise_resolve to the list of callbacks mentioned in
the comment. It also fixes a minor typo, every -> ever.
PR-URL: nodejs#33365
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebyterecodebytere mentioned this pull request Jun 9, 2020
Merged
@codebyterecodebytere mentioned this pull request Jun 28, 2020
Merged
QwireyInc pushed a commit to QwireyInc/node that referenced this pull request Apr 19, 2025
@danbev@targos
src: add promise_resolve to SetupHooks comment
7fd0519
This commit adds promise_resolve to the list of callbacks mentioned in
the comment. It also fixes a minor typo, every -> ever.
PR-URL: nodejs/node#33365
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@cjihrigcjihrigcjihrig approved these changes
@FlarnaFlarnaFlarna approved these changes

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@danbev@nodejs-github-bot@jasnell@addaleax@cjihrig@Flarna