http: tidy up exposure of header validation

[osher]

Internal refactoring, following:
Following: #33119 (comment)

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

[osher]

Ha. the change is completely internal - the tests even did not have to change 😀

[osher]

@mscdex, @addaleax - as promised :)

[osher]

mm. donno why the commit list is noisy...
I was following https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/syncing-a-fork

(first one on this for me as well, all my PRs so far started with editing a file online, and cloning the auto-generated repo)

if I'm doing something wrong - tell me, I'll fix it. even create a new PR if need be.

[addaleax]

@osher Yes, we don’t do merge commits, and it’s unfortunate that the official Github docs don’t mention that git rebase may be preferential to git merge. In particular, our CI may fail if there are merge commits. (I’ll start one anyway because I don’t think this merge commit resolves a conflict, which is what I think would throw off CI, but it might fail anyway.)

If CI works, then I think you don’t need to update anything. If it doesn’t, you’ll need to update the branch again, but this time using git rebase rather than git merge.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/31296/

[lpinca]

I guess this makes this patch semver-major?

[osher]

@lpinca - good spot. Here's the thing:

this line landed just about a week ago, and was decided to be done better as it is featured now in a discussion that continued after the landing in a friendly spirit.
It was also undocumented - it's an implementation detail.

If that's a problem - then I can leave that line.
LMK how to proceed.

[osher]

If CI works, then I think you don’t need to update anything. If it doesn’t, you’ll need to update the branch again, but this time using git rebase rather than git merge.

@addaleax

I updated the branch, just to learn how to do it. (edited: I think it also failed CI)
pls LMK if I'm on target or not...

What I basically did was

1. since all changes are in a single commit - I created a patch from it using:

git format-patch -1 HEAD

2. checkout the last commit from master, one before that auto-merge
3. create a tmp branch on it, and apply the patch to it using

git am < 0001-http-tidy-up-exposure-of-header-validation.patch

(that's the file name I got)
4. validate the patch is there using git log
5. delete patch-1.1 and create it on tmp, and delete the tmp local branch.
6. force push patch-1.1

cheers

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/31508/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/31516/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/31530/ 💚

[BridgeAR]

Landed in e30a651