Skip to content

stream: Duplex forward writableObjectMode - #33390

Closed
ronag wants to merge 2 commits into
nodejs:masterfrom
nxtedition:duplex-props
Closed

stream: Duplex forward writableObjectMode#33390
ronag wants to merge 2 commits into
nodejs:masterfrom
nxtedition:duplex-props

Conversation

@ronag

@ronagronag commented May 13, 2020

Copy link
Copy Markdown
Member

Duplex did not properly forward writableObjectMode.

Fixes: #33388

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the stream Issues and PRs related to the stream subsystem. label May 13, 2020
@ronag
ronag requested review from BridgeAR, jasnell and lpincaMay 13, 2020 19:15
@nodejs-github-bot

nodejs-github-bot commented May 13, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31314/

lpinca
lpinca approved these changes May 13, 2020
View reviewed changes
Comment threadtest/parallel/test-stream-duplex-props.js Outdated
@ronag
stream: Duplex forward writableObjectMode
3326255
Duplex did not properly forward writableObjectMode.
Fixes: nodejs#33388
@nodejs-github-bot

nodejs-github-bot commented May 13, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31315/

lpinca
lpinca reviewed May 13, 2020
View reviewed changes
Comment threadtest/parallel/test-stream-duplex-props.js
@lpinca

lpinca commented May 17, 2020

Copy link
Copy Markdown
Member

@ronag I think you accidentally pushed a spurious benchmark/streams/pipeline.js file.

@nodejs-github-bot

nodejs-github-bot commented May 17, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31365/

@nodejs-github-bot

nodejs-github-bot commented May 17, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31370/

@nodejs-github-bot

nodejs-github-bot commented May 17, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31371/

@nodejs-github-bot

nodejs-github-bot commented May 18, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31392/

@ronag

ronag commented May 18, 2020

Copy link
Copy Markdown
MemberAuthor

Landed in 2361b5c

@ronagronag closed this May 18, 2020
ronag added a commit that referenced this pull request May 18, 2020
@ronag
stream: forward writableObjectMode
2361b5c
Duplex did not properly forward writableObjectMode.
Fixes: #33388
PR-URL: #33390
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
codebytere pushed a commit that referenced this pull request May 21, 2020
@ronag@codebytere
stream: forward writableObjectMode
caa6706
Duplex did not properly forward writableObjectMode.
Fixes: #33388
PR-URL: #33390
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@codebyterecodebytere mentioned this pull request Jun 28, 2020
Merged
@codebytere

codebytere commented Jul 6, 2020

Copy link
Copy Markdown
Member

Blocked on #33079

@uwinkelvosuwinkelvos mentioned this pull request Mar 18, 2021
Closed
4 tasks
QwireyInc pushed a commit to QwireyInc/node that referenced this pull request Apr 19, 2025
@ronag@targos
stream: forward writableObjectMode
1db0d51
Duplex did not properly forward writableObjectMode.
Fixes: nodejs/node#33388
PR-URL: nodejs/node#33390
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@BridgeARBridgeARAwaiting requested review from BridgeAR
@jasnelljasnellAwaiting requested review from jasnell

Assignees

No one assigned

Labels

streamIssues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Duplex stream is not returning whether it is in object mode correctly

5 participants

@ronag@nodejs-github-bot@lpinca@codebytere@addaleax