fs: readdir fails when libuv returns UV_DIRENT_UNKNOWN and the first arg is Buffer by shackijj · Pull Request #33395 · nodejs/node

shackijj · 2020-05-14T07:36:30Z

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

shackijj · 2020-05-14T07:37:59Z

Created this PR as to check if the test fails on Ubuntu.

BridgeAR · 2020-05-23T16:53:31Z

@shackijj there is a single failure on Linux:

=== release test-fs-utils-get-dirents ===
Path: parallel/test-fs-utils-get-dirents
--- stderr ---
internal/validators.js:121
throw new ERR_INVALID_ARG_TYPE(name, 'string', value);
^
TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received an instance of Buffer
at validateString (internal/validators.js:121:11)
at Object.join (path.js:1039:7)
at getDirents (internal/fs/utils.js:188:39)
at Object.<anonymous> (/home/runner/work/node/node/test/parallel/test-fs-utils-get-dirents.js:33:5)
at Module._compile (internal/modules/cjs/loader.js:1200:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1220:10)
at Module.load (internal/modules/cjs/loader.js:1049:32)
at Function.Module._load (internal/modules/cjs/loader.js:937:14)
at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:71:12)
at internal/main/run_main_module.js:17:47 {
code: 'ERR_INVALID_ARG_TYPE'
}

shackijj · 2020-05-23T17:27:47Z

@BridgeAR thanks. I haven't implemented a fix for the bug yet. Tests fail and it's expected for now.

I'm trying to figure out how we should handle cases when we need to join a string and a Buffer, and two Buffers. Do you have any thoughs on that?

Refs: nodejs#33348

shackijj · 2020-06-16T07:20:08Z

@addaleax could you please take a look at this PR?

shackijj · 2020-06-17T06:17:17Z

Could anyone relaunch the CI pipline please?

Refs: nodejs#33348

shackijj · 2020-06-23T18:36:03Z

Could anyone relaunch the CI pipline please?

relaunched through commit

shackijj · 2020-06-24T09:43:25Z

@addaleax I made the changes that you suggested. Could you please review the code again? Should I do something else?

addaleax

Yes, thanks for the ping :)

nodejs-github-bot · 2020-06-24T09:54:00Z

CI: https://ci.nodejs.org/job/node-test-pull-request/32049/

Refs nodejs#33348 Co-authored-by: James M Snell <jasnell@gmail.com>

nodejs-github-bot · 2020-06-25T11:54:31Z

~~CI: https://ci.nodejs.org/job/node-test-pull-request/32062/~~ CI job hung on one of the rasp pis... trying again

nodejs-github-bot · 2020-06-25T13:38:47Z

CI: https://ci.nodejs.org/job/node-test-pull-request/32064/

nodejs-github-bot · 2020-06-25T15:03:04Z

CI: https://ci.nodejs.org/job/node-test-pull-request/32077/

Fixes: #33348 PR-URL: #33395 Refs: #33348 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell · 2020-06-25T19:07:50Z

Landed in 82f13fa

Fixes: #33348 PR-URL: #33395 Refs: #33348 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs-github-bot added the test Issues and PRs related to the tests. label May 14, 2020

shackijj marked this pull request as draft May 14, 2020 07:36

shackijj force-pushed the fs-readdir-buffer-input-33348 branch 4 times, most recently from f588be8 to b65f5c6Compare May 19, 2020 04:58

BridgeAR force-pushed the master branch 2 times, most recently from 8ae28ff to 2935f72Compare May 31, 2020 12:18

shackijj mentioned this pull request Jun 12, 2020
fs readdir with buffer and file types problem #33348
Closed

shackijj marked this pull request as ready for review June 13, 2020 09:12

shackijj added 3 commits June 13, 2020 16:00

fs: test readdir with a buffer as a first param
0cfa197
Refs: nodejs#33348

fs: test readdir on macOS only
a5328e2

fs: add tests for get-dirents
544ef53

shackijj force-pushed the fs-readdir-buffer-input-33348 branch from 0133675 to 0ecdfd0Compare June 13, 2020 13:00

addaleax approved these changes Jun 16, 2020
View reviewed changes

Comment threadlib/internal/fs/utils.js Outdated
Comment threadlib/internal/fs/utils.js Outdated

fs: add join function which takes Buffers and strings as args
e6d39b3
Refs: nodejs#33348

shackijj force-pushed the fs-readdir-buffer-input-33348 branch from b5d8c5c to e6d39b3Compare June 23, 2020 18:35

addaleax approved these changes Jun 24, 2020
View reviewed changes

addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fs Issues and PRs related to the fs subsystem / file system. and removed test Issues and PRs related to the tests. labels Jun 24, 2020

jasnell reviewed Jun 24, 2020
View reviewed changes

Comment threadlib/internal/fs/utils.js Outdated

jasnell approved these changes Jun 24, 2020
View reviewed changes

fs: add a space
0435053
Refs nodejs#33348 Co-authored-by: James M Snell <jasnell@gmail.com>

addaleax mentioned this pull request Jun 25, 2020
path: add Buffer support to join #34053
Draft

jasnell pushed a commit that referenced this pull request Jun 25, 2020
fs: fix readdir failure when libuv returns UV_DIRENT_UNKNOWN
82f13fa
Fixes: #33348 PR-URL: #33395 Refs: #33348 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell closed this Jun 25, 2020

codebytere pushed a commit that referenced this pull request Jun 27, 2020
fs: fix readdir failure when libuv returns UV_DIRENT_UNKNOWN
95cbfce
Fixes: #33348 PR-URL: #33395 Refs: #33348 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

github-actionsBot mentioned this pull request Jun 28, 2020
CI Relability 2020-06-28 JaneaSystems/nodejs-reliability#21
Open
15 tasks

codebytere mentioned this pull request Jun 28, 2020
v14.5.0 proposal #34093
Merged

This was referenced Jun 29, 2020
CI Relability 2020-06-29 JaneaSystems/nodejs-reliability#22
Open
CI Relability 2020-06-30 JaneaSystems/nodejs-reliability#23
Open

codebytere pushed a commit that referenced this pull request Jun 30, 2020
fs: fix readdir failure when libuv returns UV_DIRENT_UNKNOWN
024628a
Fixes: #33348 PR-URL: #33395 Refs: #33348 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

codebytere pushed a commit that referenced this pull request Jul 10, 2020
fs: fix readdir failure when libuv returns UV_DIRENT_UNKNOWN
157e7d8
Fixes: #33348 PR-URL: #33395 Refs: #33348 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

codebytere pushed a commit that referenced this pull request Jul 12, 2020
fs: fix readdir failure when libuv returns UV_DIRENT_UNKNOWN
a76fa60
Fixes: #33348 PR-URL: #33395 Refs: #33348 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

codebytere mentioned this pull request Jul 13, 2020
v12.18.3 proposal #34343
Merged

codebytere pushed a commit that referenced this pull request Jul 14, 2020
fs: fix readdir failure when libuv returns UV_DIRENT_UNKNOWN
47132ec
Fixes: #33348 PR-URL: #33395 Refs: #33348 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

Uh oh!

Uh oh!

Conversation

shackijj commented May 14, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

shackijj commented May 14, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BridgeAR commented May 23, 2020

Uh oh!

shackijj commented May 23, 2020

Uh oh!

shackijj commented Jun 16, 2020

Uh oh!

Uh oh!

Uh oh!

shackijj commented Jun 17, 2020

Uh oh!

shackijj commented Jun 23, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shackijj commented Jun 24, 2020

Uh oh!

addaleax left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Jun 24, 2020

Uh oh!

Uh oh!

nodejs-github-bot commented Jun 25, 2020• edited by jasnell Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Jun 25, 2020

Uh oh!

nodejs-github-bot commented Jun 25, 2020

Uh oh!

jasnell commented Jun 25, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

shackijj commented May 14, 2020•
edited
Loading

shackijj commented May 14, 2020•
edited
Loading

shackijj commented Jun 23, 2020•
edited
Loading

nodejs-github-bot commented Jun 25, 2020•
edited by jasnell
Loading