Uh oh!
There was an error while loading. Please reload this page.
doc: fix stream example - #33426
Closed
addaleax wants to merge 1 commit into
Closed
Conversation
- Un-break the code for multibyte characters - Get `fs.createReadStream` from the right module
devsnek
approved these changes
May 15, 2020
MylesBorins
commented
May 16, 2020
Contributor
fastrack? |
cjihrig
approved these changes
May 16, 2020
addaleax
commented
May 16, 2020
MemberAuthor
Landed in 0f232ed, thanks for the quick reviews :) |
addaleax added a commit
that referenced
this pull request
May 16, 2020
- Un-break the code for multibyte characters - Get `fs.createReadStream` from the right module PR-URL: #33426 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
codebytere pushed a commit
that referenced
this pull request
May 16, 2020
- Un-break the code for multibyte characters - Get `fs.createReadStream` from the right module PR-URL: #33426 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fs.createReadStreamfrom the right moduleChecklist
make -j4 test(UNIX), orvcbuild test(Windows) passes