Skip to content

worker: use _writev in internal communication - #33454

Closed
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:worker-writev
Closed

worker: use _writev in internal communication#33454
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:worker-writev

Conversation

@addaleax

@addaleaxaddaleax commented May 18, 2020

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the worker Issues and PRs related to Worker support. label May 18, 2020
@nodejs-github-bot

nodejs-github-bot commented May 18, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31380/

benjamingr
benjamingr approved these changes May 18, 2020
View reviewed changes

@benjamingrbenjamingr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM.

The only concern I have here is whether or not we can somehow pass too much data here by postMessageing all the chunks at once. Also am a bit disappointed we don't have a niftier API for pushing multiple things at once (like Array.prototype.push has).

@addaleax

addaleax commented May 18, 2020

Copy link
Copy Markdown
MemberAuthor

The only concern I have here is whether or not we can somehow pass too much data here by postMessageing all the chunks at once.

It’s only going to postMessage() data that is already being queued up, so I don’t think the effect should be too noticable?

Also am a bit disappointed we don't have a niftier API for pushing multiple things at once (like Array.prototype.push has).

Not sure, are you referring to postMessage() here? So, sending multiple messages at once? I’m not sure that that would make a noticeable difference…

@addaleaxaddaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 18, 2020
@nodejs-github-bot

nodejs-github-bot commented May 18, 2020•
edited by addaleax
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31388/ (:yellow_heart:)

addaleax added a commit that referenced this pull request May 20, 2020
@addaleax
worker: use _writev in internal communication
d2a6f06
PR-URL: #33454
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@addaleax

addaleax commented May 20, 2020

Copy link
Copy Markdown
MemberAuthor

Landed in d2a6f06

@addaleax
addaleax deleted the worker-writev branch May 20, 2020 10:37
codebytere pushed a commit that referenced this pull request Jun 18, 2020
@addaleax@codebytere
worker: use _writev in internal communication
64cae13
PR-URL: #33454
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@codebyterecodebytere mentioned this pull request Jun 28, 2020
Merged
codebytere pushed a commit that referenced this pull request Jul 6, 2020
@addaleax@codebytere
worker: use _writev in internal communication
c502384
PR-URL: #33454
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@codebyterecodebytere mentioned this pull request Jul 13, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@benjamingrbenjamingrbenjamingr approved these changes
@lpincalpincalpinca approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.workerIssues and PRs related to Worker support.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@addaleax@nodejs-github-bot@jasnell@benjamingr@lpinca