crypto: fix wrong error message by benbucksch · Pull Request #33482 · nodejs/node

benbucksch · 2020-05-20T13:06:31Z

When calling crypto.sign(), if the key parameter object is
missing the key property, the error message is wrong.

Before the fix:
TypeError [ERR_INVALID_ARG_TYPE]: The "key" argument must be of
type string or an instance of Buffer, TypedArray, DataView, or
KeyObject. Received an instance of Object

Expected:
TypeError [ERR_INVALID_ARG_TYPE]: The "key.key" property
must be of type string or an instance of Buffer, TypedArray,
DataView, or KeyObject. Received undefined

Fixes: #33480
This seems like a copy&paste bug. Somebody copied from the end of
the function, where this is correct, to here, where it's wrong.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

When calling `crypto.sign()`, if the `key` parameter object is missing the `key` property, the error message is wrong. Before the fix: TypeError [ERR_INVALID_ARG_TYPE]: The "key" argument must be of type string or an instance of Buffer, TypedArray, DataView, or KeyObject. Received an instance of Object Expected: TypeError [ERR_INVALID_ARG_TYPE]: The "key.key property" argument must be of type string or an instance of Buffer, TypedArray, DataView, or KeyObject. Received undefined Fixes: #33480 This seems like a copy&paste bug. Somebody copied from the end of the function, where this is correct, to here, where it's wrong.

benbucksch · 2020-05-20T13:10:18Z

(removed comment regarding failed test)

himself65

and unit tests need an update too

benbucksch · 2020-05-20T14:01:27Z

and unit tests need an update too

I'm on it.

benbucksch · 2020-05-20T15:07:24Z

Review change done. Tests fixed.

benbucksch · 2020-05-20T22:21:29Z

Ready to merge.

Seems like the tests pass.

BridgeAR

LGTM. Great work and good catch!

nodejs-github-bot · 2020-05-23T15:50:58Z

CI: https://ci.nodejs.org/job/node-test-pull-request/31502/

nodejs-github-bot · 2020-05-23T18:46:43Z

CI: https://ci.nodejs.org/job/node-test-pull-request/31514/ 💚

BridgeAR · 2020-05-23T20:00:48Z

@nodejs/crypto this could use another review.

ryzokuken

LGTM. Thanks for the ping, @BridgeAR.

When calling `crypto.sign()`, if the `key` parameter object is missing the `key` property, the error message is wrong. Before the fix: TypeError [ERR_INVALID_ARG_TYPE]: The "key" argument must be of type string or an instance of Buffer, TypedArray, DataView, or KeyObject. Received an instance of Object Expected: TypeError [ERR_INVALID_ARG_TYPE]: The "key.key property" argument must be of type string or an instance of Buffer, TypedArray, DataView, or KeyObject. Received undefined This seems like a copy&paste bug. Somebody copied from the end of the function, where this is correct, to here, where it's wrong. PR-URL: nodejs#33482Fixes: nodejs#33480 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>

BridgeAR · 2020-05-25T17:19:42Z

Landed in 2f00ca4

benbucksch · 2020-05-26T00:34:21Z

Thanks! :)

When calling `crypto.sign()`, if the `key` parameter object is missing the `key` property, the error message is wrong. Before the fix: TypeError [ERR_INVALID_ARG_TYPE]: The "key" argument must be of type string or an instance of Buffer, TypedArray, DataView, or KeyObject. Received an instance of Object Expected: TypeError [ERR_INVALID_ARG_TYPE]: The "key.key property" argument must be of type string or an instance of Buffer, TypedArray, DataView, or KeyObject. Received undefined This seems like a copy&paste bug. Somebody copied from the end of the function, where this is correct, to here, where it's wrong. PR-URL: #33482Fixes: #33480 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>

eezhi · 2020-10-15T02:38:16Z

I get this error when i run 'knex migrate:latest" and I have no idea how to fix it. Been on it for days

benbucksch · 2020-10-15T11:34:24Z

@eezhi : If you get this error message, you (or whoever wrote the code you run) are using the API wrong, specifically the type of one of your parameters is wrong. The API here is very confusing, because it accepts several different types for backward compat, so please read the docs very very carefully and slowly. I had severe trouble to understand it as well.

If you still can't figure it out, post somewhere on a developer help forum. This ticket here is not the right place for getting help about your problem.

eezhi · 2020-10-16T16:20:45Z

@eezhi : If you get this error message, you (or whoever wrote the code you run) are using the API wrong, specifically the type of one of your parameters is wrong. The API here is very confusing, because it accepts several different types for backward compat, so please read the docs very very carefully and slowly. I had severe trouble to understand it as well.
If you still can't figure it out, post somewhere on a developer help forum. This ticket here is not the right place for getting help about your problem.

Alright thanks

nodejs-github-bot added the crypto Issues and PRs related to the crypto subsystem. label May 20, 2020

Adapt test to new error message
0fb7721

himself65 reviewed May 20, 2020
View reviewed changes

Comment threadlib/internal/crypto/keys.js Outdated

himself65 reviewed May 20, 2020
View reviewed changes

benbucksch added 2 commits May 20, 2020 16:40

Review comment
8b06217

Adapt tests
2148e9a

himself65 reviewed May 20, 2020
View reviewed changes

Comment threadtest/parallel/test-crypto-sign-verify.js Outdated

NIT: Remove unnecessary change
c4a3d0c

BridgeAR approved these changes May 23, 2020
View reviewed changes

BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 23, 2020

ryzokuken approved these changes May 25, 2020
View reviewed changes

BridgeAR closed this May 25, 2020

benbucksch deleted the crypto-error branch May 26, 2020 00:34

codebytere mentioned this pull request Jun 28, 2020
v14.5.0 proposal #34093
Merged

codebytere mentioned this pull request Jul 13, 2020
v12.18.3 proposal #34343
Merged

Uh oh!

Uh oh!

Conversation

benbucksch commented May 20, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

benbucksch commented May 20, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

himself65 left a comment

Choose a reason for hiding this comment

Uh oh!

benbucksch commented May 20, 2020

Uh oh!

benbucksch commented May 20, 2020

Uh oh!

Uh oh!

benbucksch commented May 20, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BridgeAR left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented May 23, 2020

Uh oh!

nodejs-github-bot commented May 23, 2020• edited by BridgeAR Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BridgeAR commented May 23, 2020

Uh oh!

ryzokuken left a comment

Choose a reason for hiding this comment

Uh oh!

BridgeAR commented May 25, 2020

Uh oh!

benbucksch commented May 26, 2020

Uh oh!

eezhi commented Oct 15, 2020

Uh oh!

benbucksch commented Oct 15, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eezhi commented Oct 16, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

benbucksch commented May 20, 2020•
edited
Loading

benbucksch commented May 20, 2020•
edited
Loading

benbucksch commented May 20, 2020•
edited
Loading

nodejs-github-bot commented May 23, 2020•
edited by BridgeAR
Loading

benbucksch commented Oct 15, 2020•
edited
Loading