Uh oh!
There was an error while loading. Please reload this page.
cli: support --experimental-top-level-await in NODE_OPTIONS - #33495
Closed
dfabulich wants to merge 1 commit into
Closed
cli: support --experimental-top-level-await in NODE_OPTIONS#33495dfabulich wants to merge 1 commit into
dfabulich wants to merge 1 commit into
Conversation
2 tasks
BridgeAR
left a comment
Member
There was a problem hiding this comment.
Please add a test in test/parallel/test-cli-node-options.js
cjihrig
approved these changes
May 21, 2020
devsnek
commented
May 21, 2020
Member
it is weird to me that we allow experimental options in the env |
dfabulich
commented
May 21, 2020
ContributorAuthor
Test added. Note that this test won't verify |
dfabulich
commented
May 22, 2020
ContributorAuthor
I think this PR should be author ready? |
BridgeAR
approved these changes
May 23, 2020
BridgeAR
commented
May 23, 2020
Member
@dfabulich a PR is considered |
nodejs-github-bot
commented
May 23, 2020
Collaborator
targos
approved these changes
May 23, 2020
BridgeAR pushed a commit
to BridgeAR/node
that referenced
this pull request
May 23, 2020
PR-URL: nodejs#33495 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
BridgeAR
commented
May 23, 2020
Member
Landed in 842a895 🎉 |
codebytere pushed a commit
that referenced
this pull request
Jun 18, 2020
PR-URL: #33495 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
codebytere pushed a commit
that referenced
this pull request
Jun 18, 2020
PR-URL: #33495 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
codebytere pushed a commit
that referenced
this pull request
Jun 30, 2020
PR-URL: #33495 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes