Uh oh!
There was an error while loading. Please reload this page.
test: make flaky test stricter - #33539
Closed
ronag wants to merge 1 commit into
Closed
Conversation
MemberAuthor
Make assertions in flaky test stricter to possibly make it easier to determine the root cause. Refs: nodejs#4066
ronag
commented
May 25, 2020
MemberAuthor
Haven't been able to make the flaky test fail to debug this and it's unclear how it hits the failure. I've made the test a bit stricter hoping that future failures maight provide more information. |
nodejs-github-bot
commented
May 25, 2020
Collaborator
BridgeAR
commented
May 25, 2020
Member
The error that came up was |
ronag
commented
May 25, 2020
MemberAuthor
Yes, but that should not happen unless it gets into the "response" state. Which this change ensures it should not. |
jasnell
approved these changes
May 25, 2020
lpinca
approved these changes
May 26, 2020
ronag
commented
May 26, 2020
MemberAuthor
Landed in 9949a2e |
ronag added a commit
that referenced
this pull request
May 26, 2020
Make assertions in flaky test stricter to possibly make it easier to determine the root cause. Refs: #4066 PR-URL: #33539 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
codebytere pushed a commit
that referenced
this pull request
Jun 18, 2020
Make assertions in flaky test stricter to possibly make it easier to determine the root cause. Refs: #4066 PR-URL: #33539 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
codebytere pushed a commit
that referenced
this pull request
Jun 30, 2020
Make assertions in flaky test stricter to possibly make it easier to determine the root cause. Refs: #4066 PR-URL: #33539 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
codebytere pushed a commit
that referenced
this pull request
Jul 8, 2020
Make assertions in flaky test stricter to possibly make it easier to determine the root cause. Refs: #4066 PR-URL: #33539 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #4066
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes