Uh oh!
There was an error while loading. Please reload this page.
Update buffer.md - #33547
Closed
tomanagle wants to merge 2 commits into
Closed
Conversation
Trott
reviewed
May 27, 2020
Uh oh!
There was an error while loading. Please reload this page.
Trott
previously requested changes
May 27, 2020
Trott
left a comment
Member
There was a problem hiding this comment.
Comma position needs to be restored.
Co-authored-by: Rich Trott <rtrott@gmail.com>
BridgeAR
approved these changes
May 27, 2020
gireeshpunathil
approved these changes
May 28, 2020
jasnell
approved these changes
May 28, 2020
BridgeAR
dismissed
Trott’s stale reviewMay 30, 2020 00:52
The blocking comment is addressed as requested. PTAL
BridgeAR pushed a commit
to BridgeAR/node
that referenced
this pull request
May 30, 2020
PR-URL: nodejs#33547 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR
commented
May 30, 2020
Member
Landed in 5e77c67 |
Trott
commented
May 31, 2020
Member
Belated LGTM. Thanks for the fix! |
codebytere pushed a commit
that referenced
this pull request
Jun 18, 2020
PR-URL: #33547 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
codebytere pushed a commit
that referenced
this pull request
Jun 30, 2020
PR-URL: #33547 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere pushed a commit
that referenced
this pull request
Jul 9, 2020
PR-URL: #33547 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the sentence structure by removing a floating
sand offsets the interruptingin generalwith commas.