Skip to content

src: simplify MaybeStackBuffer::capacity() - #33602

Closed
bnoordhuis wants to merge 1 commit into
nodejs:masterfrom
bnoordhuis:simplify-maybestackbuffer-capacity
Closed

src: simplify MaybeStackBuffer::capacity()#33602
bnoordhuis wants to merge 1 commit into
nodejs:masterfrom
bnoordhuis:simplify-maybestackbuffer-capacity

Conversation

@bnoordhuis

@bnoordhuisbnoordhuis commented May 28, 2020

Copy link
Copy Markdown
Member

No description provided.

@nodejs-github-botnodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label May 28, 2020
@nodejs-github-bot

nodejs-github-bot commented May 28, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31606/

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 28, 2020
jasnell pushed a commit that referenced this pull request May 30, 2020
@bnoordhuis@jasnell
src: simplify MaybeStackBuffer::capacity()
2935f72
PR-URL: #33602
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@jasnell

jasnell commented May 30, 2020

Copy link
Copy Markdown
Member

Landed in 2935f72

@jasnelljasnell closed this May 30, 2020
codebytere pushed a commit that referenced this pull request Jun 18, 2020
@bnoordhuis@codebytere
src: simplify MaybeStackBuffer::capacity()
c3728c6
PR-URL: #33602
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@codebyterecodebytere mentioned this pull request Jun 28, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 30, 2020
@bnoordhuis@codebytere
src: simplify MaybeStackBuffer::capacity()
b2d3c58
PR-URL: #33602
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
codebytere pushed a commit that referenced this pull request Jul 9, 2020
@bnoordhuis@codebytere
src: simplify MaybeStackBuffer::capacity()
eb8d6f5
PR-URL: #33602
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@codebyterecodebytere mentioned this pull request Jul 13, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@benjamingrbenjamingrbenjamingr approved these changes
@himself65himself65himself65 approved these changes
@juanarboljuanarboljuanarbol approved these changes
+1 more reviewer
@devnexendevnexendevnexen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@bnoordhuis@nodejs-github-bot@jasnell@addaleax@benjamingr@devnexen@himself65@juanarbol@BridgeAR