http: add res.req and res.redirect()

[XadillaX]

Add res.req and res.redirect() in http server for convenience.

Fixes: #28673

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

[jasnell]

I appreciate the work on this but I think I'm -1 on this. It expands the API surface in a way that frameworks that build on the core apis already handle very well.

[XadillaX]

I appreciate the work on this but I think I'm -1 on this. It expands the API surface in a way that frameworks that build on the core apis already handle very well.

Hmmmm, IMHO, the point is that not only one framework do that.

[BridgeAR]

It expands the API surface in a way that frameworks that build on the core apis already handle very well.

I don't think that's an argument against this. It would probably be good to get feedback from maintainers of some of the frameworks @wesleytodd@dougwilson@mcollina.

[BridgeAR]

@nodejs/http @nodejs/http2 PTAL

[lpinca]

I'm also -1. I think this is outside of "core" scope.

[mcollina]

I am -1 as well because these core methods will be shadowed by express or will be useless as the other frameworks do not use them.

Generically, I regret having such a rich API for http.

[wesleytodd]

I am not completely opposed, but this would probably be something we should discuss in conjunction with the frameworks. If this was implemented in core it would be overridden in express and other frameworks.

Most users would not get the direct benefit until the frameworks wrapped it instead of their implementations, and in this case express has a different method signature. We attempt to be a light wrapper around core, this would be an exception and would require a breaking change for us to align with core.

All that said, I think we should have a clear conversation about why we think these things which basically all frameworks implement (even if they do it well) are not in core. Maybe this would be something to add to a future @nodejs/web-server-frameworks agenda?

[ronag]

I would rather not increase the API surface and leave this to user land.

I think this is a good topic for the @nodejs/web-server-frameworks agenda.

[ghermeto]

I agree with @jasnell and I believe that we should only increase the public core API where it makes most impact.

#28673 doesn't make a compelling argument that this will benefit the majority of the users (as frameworks already do it) or that the alternative (passing req as a param) is too hard.

[XadillaX]

Okay, we can keep discussing then.

[styfle]

res.req was implemented in PR #36505

[XadillaX]

How about redirect()?

[styfle]

I would prefer redirect() that matches the Express.js API.

But I agree with the sentiment that there's not a lot of value in 1 line res.redirect(url, 302)
vs 2 lines res.statusCode=302; res.setHeader('Location',url).

And what should the default status code even be? 301, 302, 307, 308?

Since this PR has no upvotes, I would say we don't need it in core.

[bl-ue]

This should probably be closed as the general consensus is that it's not a good idea.