Skip to content

events: add event-target tests - #33623

Closed
benjamingr wants to merge 2 commits into
nodejs:masterfrom
benjamingr:event-compat-3
Closed

events: add event-target tests#33623
benjamingr wants to merge 2 commits into
nodejs:masterfrom
benjamingr:event-compat-3

Conversation

@benjamingr

@benjamingrbenjamingr commented May 28, 2020

Copy link
Copy Markdown
Member

Add tests for several scenarios:

  • Add tests for event names that are prototype methods.
  • Add test for events.on with NodeEventTarget
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@benjamingrbenjamingr added the events Issues and PRs related to the events subsystem / EventEmitter. label May 28, 2020
@benjamingr
benjamingr requested a review from jasnellMay 28, 2020 18:47
@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label May 28, 2020
@benjamingr

benjamingr commented May 29, 2020

Copy link
Copy Markdown
MemberAuthor

@jasnell I think you missed this one :]

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 30, 2020
@nodejs-github-bot

nodejs-github-bot commented May 30, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31645/

benjamingr added a commit that referenced this pull request May 31, 2020
@benjamingrBenjamin Gruenbaum
events: add event-target tests
e94efeb
PR-URL: #33623
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@benjamingr

benjamingr commented May 31, 2020•
edited by BridgeAR
Loading

Copy link
Copy Markdown
MemberAuthor

landed in e94efeb 🎉

benjamingr added a commit that referenced this pull request May 31, 2020
@benjamingrBenjamin Gruenbaum
events: add event-target tests
df4eda2
PR-URL: #33623
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeARBridgeAR reopened this May 31, 2020
@lundibundilundibundi mentioned this pull request May 31, 2020
Closed
2 tasks
@nodejs-github-bot

nodejs-github-bot commented Jun 6, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31744/

@nodejs-github-bot

nodejs-github-bot commented Jun 17, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31909/

@jasnell

jasnell commented Jun 17, 2020

Copy link
Copy Markdown
Member

Ping @benjamingr ... tests are failing here.

This was referenced Jun 18, 2020
Open
Open
@jasnelljasnell added eventtarget Issues and PRs related to the EventTarget implementation. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jun 19, 2020
This was referenced Jun 20, 2020
Open
Open
benjamingr added a commit to benjamingr/io.js that referenced this pull request Jun 21, 2020
@benjamingrBenjamin Gruenbaum
events: add event-target tests
d2b9e56
PR-URL: nodejs#33623
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@benjamingr

benjamingr commented Jun 21, 2020

Copy link
Copy Markdown
MemberAuthor

superceded already. Sorry forgot to close.

@github-actionsgithub-actionsBot mentioned this pull request Jun 22, 2020
Open
30 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@BridgeARBridgeARBridgeAR approved these changes

Assignees

No one assigned

Labels

eventsIssues and PRs related to the events subsystem / EventEmitter.eventtargetIssues and PRs related to the EventTarget implementation.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@benjamingr@nodejs-github-bot@jasnell@BridgeAR