Skip to content

doc: update wasi code sample - #33626

Merged
Trott merged 0 commit into
nodejs:masterfrom
pragyandas:patch-1
Jun 19, 2020
Merged

doc: update wasi code sample#33626
Trott merged 0 commit into
nodejs:masterfrom
pragyandas:patch-1

Conversation

@pragyandas

@pragyandaspragyandas commented May 28, 2020

Copy link
Copy Markdown
Contributor

wasi: update code sample

Code sample updated by adding a hello-world (demo.wat) code example. Step for compiling .wat to .wasm added (with reference to wabt tools). The sample code prints "hello world\n" in the console. Note: This update can be treated as an extension to the existing sample.

Checklist

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. wasi Issues and PRs related to the WebAssembly System Interface. labels May 28, 2020
@addaleaxaddaleax changed the title wasi: update code sampledoc: update wasi code sampleMay 29, 2020
addaleax
addaleax approved these changes May 29, 2020
View reviewed changes

@addaleaxaddaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the linter failures addressed

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 30, 2020
@BridgeAR
BridgeARforce-pushed the master branch 2 times, most recently from 8ae28ff to 2935f72CompareMay 31, 2020 12:18
@reklatsmasters

reklatsmasters commented Jun 3, 2020

Copy link
Copy Markdown
Contributor

Just note. you actually don’t need wabt or wat2wasm tools. You may use webassembly extension for vscode to compile wat to wasm.

@pragyandas

pragyandas commented Jun 4, 2020•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Just note. you actually don’t need wabt or wat2wasm tools. You may use webassembly extension for vscode to compile wat to wasm.

@reklatsmasters VSCode webassembly extension uses wabt as a dependency (see package.json), which is a JS port of wabt. Moreover, I don't think VSCode extension is a standard way of compiling wat to wasm, but can be an option to consider for VSCode users.

@addaleax

addaleax commented Jun 19, 2020

Copy link
Copy Markdown
Member

Landed in f5ec98c, thanks for the PR! 🎉

addaleax pushed a commit that referenced this pull request Jun 19, 2020
@pragyandas@addaleax
doc: update wasi code sample
f5ec98c
- Code sample updated by adding a hello-world (`demo.wat`) code example
- Step for compiling `.wat` to `.wasm` added (with reference to
`wabt` tools)
- The sample code prints "hello world\n" in the console
Note: This update adds a very minimal change to the existing sample and
can be treated as an extension.
PR-URL: #33626
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@addaleax

addaleax commented Jun 19, 2020

Copy link
Copy Markdown
Member

Actually, I had to back this out of master because this conflicts with the linter rules introduced by 0ef6956 …

@Trott or @DerekNonGeneric Could you push a fixup commit to this PR and then land this? I’m not sure what the linter expects here myself.

@addaleaxaddaleax reopened this Jun 19, 2020
Trott
Trott reviewed Jun 19, 2020
View reviewed changes
Comment threaddoc/api/wasi.md Outdated
Trott
Trott reviewed Jun 19, 2020
View reviewed changes
Comment threaddoc/api/wasi.md Outdated
@Trott

Trott commented Jun 19, 2020

Copy link
Copy Markdown
Member

@Trott or @DerekNonGeneric Could you push a fixup commit to this PR and then land this? I’m not sure what the linter expects here myself.

I'll make a judgment call and push a fixup commit (and then land, and then open a PR to get the lint presets updated if appropriate).

Trott
Trott reviewed Jun 19, 2020
View reviewed changes
Comment threaddoc/api/wasi.md Outdated
@Trott

Trott commented Jun 19, 2020

Copy link
Copy Markdown
Member

Fixed-up and force-pushed.

Trott
Trott approved these changes Jun 19, 2020
View reviewed changes

@TrottTrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green

@Trott

Trott commented Jun 19, 2020

Copy link
Copy Markdown
Member

All the linters came back green. Landing.

@TrottTrott closed this Jun 19, 2020
@Trott

Trott commented Jun 19, 2020

Copy link
Copy Markdown
Member

Landed in 343cf1b

@Trott
Trott merged commit 343cf1b into nodejs:masterJun 19, 2020
codebytere pushed a commit that referenced this pull request Jun 27, 2020
@pragyandas@codebytere
doc: update WASM code sample
72e2fd3
- Code sample updated by adding a hello-world (`demo.wat`) code example
- Step for compiling `.wat` to `.wasm` added (with reference to `wabt`
tools)
- The sample code prints "hello world\n" in the console
This update adds a very minimal change to the existing sample and can be
treated as an extension.
PR-URL: #33626
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebyterecodebytere mentioned this pull request Jun 28, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 30, 2020
@pragyandas@codebytere
doc: update WASM code sample
24e6de8
- Code sample updated by adding a hello-world (`demo.wat`) code example
- Step for compiling `.wat` to `.wasm` added (with reference to `wabt`
tools)
- The sample code prints "hello world\n" in the console
This update adds a very minimal change to the existing sample and can be
treated as an extension.
PR-URL: #33626
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
codebytere pushed a commit that referenced this pull request Jul 10, 2020
@pragyandas@codebytere
doc: update WASM code sample
5e375e7
- Code sample updated by adding a hello-world (`demo.wat`) code example
- Step for compiling `.wat` to `.wasm` added (with reference to `wabt`
tools)
- The sample code prints "hello world\n" in the console
This update adds a very minimal change to the existing sample and can be
treated as an extension.
PR-URL: #33626
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
codebytere pushed a commit that referenced this pull request Jul 12, 2020
@pragyandas@codebytere
doc: update WASM code sample
410b233
- Code sample updated by adding a hello-world (`demo.wat`) code example
- Step for compiling `.wat` to `.wasm` added (with reference to `wabt`
tools)
- The sample code prints "hello world\n" in the console
This update adds a very minimal change to the existing sample and can be
treated as an extension.
PR-URL: #33626
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebyterecodebytere mentioned this pull request Jul 13, 2020
Merged
codebytere pushed a commit that referenced this pull request Jul 14, 2020
@pragyandas@codebytere
doc: update WASM code sample
5ee9509
- Code sample updated by adding a hello-world (`demo.wat`) code example
- Step for compiling `.wat` to `.wasm` added (with reference to `wabt`
tools)
- The sample code prints "hello world\n" in the console
This update adds a very minimal change to the existing sample and can be
treated as an extension.
PR-URL: #33626
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes
@addaleaxaddaleaxaddaleax approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.wasiIssues and PRs related to the WebAssembly System Interface.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@pragyandas@reklatsmasters@addaleax@Trott@BridgeAR@nodejs-github-bot