test: improve http-client coverage

[KuthorX]

Based on https://coverage.nodejs.org/coverage-d12d5ef3ef8e5d9f/lib/_http_client.js.html, I try to improve coverage to line 120 (http-client-input-function), 194-197 (http-client-insecure-http-parser-error)

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• commit message follows commit guidelines

[BridgeAR]

Suggested change

	code: /ERR_INVALID_ARG_TYPE/
	code: 'ERR_INVALID_ARG_TYPE',
	message: /insecureHTTPParser/

[BridgeAR]

The test should definitely hit the mentioned code line but it would be great to write a test that actually verifies that the callback is also called and ideally, this test case would not cause any errors, since it's a legit code path.

[KuthorX]

@BridgeAR Here is a rewrote version, which can make cb be called, but it's a little longer than previous version, so I am not sure whether it's ok, could you help me to check?

'use strict';constcommon=require('../common');consthttp=require('http');constassert=require('assert');constClientRequest=require('http').ClientRequest;{constserver=http.createServer(common.mustCall((req,res)=>{res.writeHead(200);res.end('hello world');})).listen(80,'127.0.0.1');constreq=newClientRequest(common.mustCall((response)=>{letbody='';response.setEncoding('utf8');response.on('data',(chunk)=>{body+=chunk;});response.on('end',common.mustCall(()=>{assert.strictEqual(body,'hello world');server.close();}));}));req.end();}

[BridgeAR]

@KuthorX thank you very much for your contribution! This is already looking pretty good, just left two minor comments.

[KuthorX]

Could someone help me to review lastest commit? Any suggestion will be appreciated.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/35061/

[aduh95]

Ping @nodejs/http for reviews.

[ShogunPanda]

The changes look fine to me. There is only one test failing as you're using port 80. Can you use another port?

[KuthorX]

The changes look fine to me. There is only one test failing as you're using port 80. Can you use another port?

thanks, has changed to 8080

[ShogunPanda]

LGTM!

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/54662/

[KuthorX]

looks like some ci fail, maybe I should merge main branch? @ShogunPanda

[mcollina]

lgtm

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/54695/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/55315/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/55329/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/56067/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/56358/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/56379/

[nodejs-github-bot]

Landed in c925039

[KuthorX]

After 3 years, it merged, thank you guys 😌