Skip to content

querystring: improve stringify() performance - #33669

Merged
mscdex merged 1 commit into
nodejs:masterfrom
mscdex:querystring-stringify-perf
Jun 13, 2020
Merged

querystring: improve stringify() performance#33669
mscdex merged 1 commit into
nodejs:masterfrom
mscdex:querystring-stringify-perf

Conversation

@mscdex

@mscdexmscdex commented May 31, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Benchmark results:

 confidence improvement accuracy (*) (**) (***)
querystring/querystring-stringify.js n=1000000 type='array' *** 27.37 % ±0.86% ±1.15% ±1.50%
querystring/querystring-stringify.js n=1000000 type='encodelast' *** 19.40 % ±1.27% ±1.70% ±2.24%
querystring/querystring-stringify.js n=1000000 type='encodemany' *** 9.39 % ±1.33% ±1.78% ±2.34%
querystring/querystring-stringify.js n=1000000 type='multiprimitives' *** 56.64 % ±1.93% ±2.59% ±3.43%
querystring/querystring-stringify.js n=1000000 type='noencode' *** 26.66 % ±4.15% ±5.59% ±7.41%
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@mscdexmscdex added querystring Issues and PRs related to the built-in querystring module. performance Issues and PRs related to the performance of Node.js. labels May 31, 2020
@nodejs-github-bot

nodejs-github-bot commented May 31, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31666/

@benjamingr

benjamingr commented May 31, 2020

Copy link
Copy Markdown
Member

@bricss why are you upvoting every new PR :D?

@BridgeAR
BridgeARforce-pushed the master branch 2 times, most recently from 8ae28ff to 2935f72CompareMay 31, 2020 12:18
@bricss

bricss commented May 31, 2020

Copy link
Copy Markdown
Contributor

@benjamingr I wouldn't consider this as a upvote, but as regular like 🙂

BridgeAR
BridgeAR reviewed May 31, 2020
View reviewed changes
Comment threadlib/querystring.js Outdated
Comment threadlib/querystring.js Outdated
Comment threadlib/querystring.js Outdated
@mscdex
mscdexforce-pushed the querystring-stringify-perf branch 2 times, most recently from d4c300d to 0ce72f8CompareJune 2, 2020 14:45
@nodejs-github-bot

nodejs-github-bot commented Jun 2, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31701/

@mscdex
mscdexforce-pushed the querystring-stringify-perf branch from 0ce72f8 to 06bdb24CompareJune 3, 2020 02:29
@mscdex

mscdex commented Jun 3, 2020

Copy link
Copy Markdown
ContributorAuthor

I've made further changes that have netted even larger improvements across the board.

@nodejs-github-bot

nodejs-github-bot commented Jun 3, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31702/

@mscdex
querystring: improve stringify() performance
7b46793
PR-URL: nodejs#33669
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@mscdex
mscdexforce-pushed the querystring-stringify-perf branch from 06bdb24 to 7b46793CompareJune 12, 2020 22:22
@nodejs-github-bot

nodejs-github-bot commented Jun 12, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31852/

@mscdex
mscdex merged commit 7b46793 into nodejs:masterJun 13, 2020
@mscdex
mscdex deleted the querystring-stringify-perf branch June 13, 2020 01:18
@github-actionsgithub-actionsBot mentioned this pull request Jun 18, 2020
Open
18 tasks
codebytere pushed a commit that referenced this pull request Jun 18, 2020
@mscdex@codebytere
querystring: improve stringify() performance
e8572e7
PR-URL: #33669
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Jun 19, 2020
Open
36 tasks
@codebyterecodebytere mentioned this pull request Jun 28, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 30, 2020
@mscdex@codebytere
querystring: improve stringify() performance
c85bf0a
PR-URL: #33669
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
codebytere pushed a commit that referenced this pull request Jul 10, 2020
@mscdex@codebytere
querystring: improve stringify() performance
13b693f
PR-URL: #33669
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@codebyterecodebytere mentioned this pull request Jul 13, 2020
Merged
codebytere pushed a commit that referenced this pull request Jul 14, 2020
@mscdex@codebytere
querystring: improve stringify() performance
b461e93
PR-URL: #33669
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BridgeARBridgeARBridgeAR left review comments
@benjamingrbenjamingrbenjamingr approved these changes

Assignees

No one assigned

Labels

performanceIssues and PRs related to the performance of Node.js.querystringIssues and PRs related to the built-in querystring module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mscdex@nodejs-github-bot@benjamingr@bricss@BridgeAR