.exit message

[hemanth]

^

[pselle]

I would put that in the same parentheses as the ^C message, otherwise I 👍 this change!

[jasnell]

Needs a proper commit message and PR description. Please see https://github.com/nodejs/node/blob/master/CONTRIBUTING.md

[silverwind]

-1, I think the current message is sufficient. It makes no sense to input .exit after a CTRL-C, when one can just .exit without the preceding keypress.

[hemanth]

@jasnell, sorry missed that, OK with the branch name or shall I do a fresh one?

@pselle I was in a dilama :\

[jasnell]

@hemanth .. the branch name is inconsequential. Please note @silverwind's objection, however.

[pselle]

So this is a usability/docs note. While it makes sense to use ^C after used once, the idea is to educate the user that .exit is also an exit option

[RobAtticus]

I did learn from this the existence of .exit, so as a user I think this would be helpful.

[ronkorving]

Wow, I learned something today. But I would rephrase "use" to something like "type". The first impression I had when reading "use .exit" was that it would mean "use the process.exit method".

I am however completely missing the point of the existence of .exit. What's the use case? My fingers are already on the CTRL-C buttons, why would I start typing ".exit" instead?

[thefourtheye]

I second @silverwind here. Normally when I press Ctrl + C (or Ctrl + D), I expect the program to terminate. But, if it doesn't then I would expect some valid message being shown to me. In this case, the message being printed looks perfectly fine to me.

[Fishrock123]

Considering this is only on an interrupt, I'm not sure if it makes sense?

[hemanth]

the idea is to educate the user that .exit is also an exit option

^ +1

Considering this is only on an interrupt, I'm not sure if it makes sense?

Not sure

It makes no sense to input .exit after a CTRL-C

Agree!

[jasnell]

@hemanth ... this is a good step, but I think something like the following would be better:

self.output.write('(To exit, press ^C again or type .exit)\n');

[pselle]

+1 to @jasnell 's wording.

[jasnell]

@hemanth ... would you be able/willing to update the PR with the suggested wording in #3368 (comment)?

[hemanth]

@jasnell Done.

[jasnell]

LGTM!

[jasnell]

Oh... one last thing... can you squash the commits and fix up the commit log to follow the standard format? https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit

[hemanth]

@jasnell Looks fine now?

[jasnell]

Yes perfect. Thank you!

[jasnell]

Landed in 354f9ce

[hemanth]

👍 Thanks!

[MylesBorins]

landed in lts-v4.x-staging as bf48969

[hemanth]

👍 Thanks.