Uh oh!
There was an error while loading. Please reload this page.
build: fix compiling addons with older versions of Node.js - #33688
Merged
Conversation
nodejs-github-bot
commented
Jun 1, 2020
Collaborator
2 tasks
lpinca
approved these changes
Jun 2, 2020
targos
approved these changes
Jun 2, 2020
bnoordhuis
approved these changes
Jun 2, 2020
nodejs-github-bot
commented
Jun 2, 2020
Collaborator
`common.gypi` is used by `node-gyp` to compile addons. Default values must be provided for variables that may not exist on older versions of Node.js so that older versions of Node.js can be used to compile addons for later versions of Node.js. Add default values for `v8_enable_pointer_compression` and `v8_enable_31bit_smis_on_64bit_arch`. PR-URL: nodejs#33688 Refs: nodejs#30463 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Signed-off-by: Richard Lau <riclau@uk.ibm.com>
richardlauforce-pushed
the
init-v8-build-vars
branch
from
June 4, 2020 08:54
ab02b95 to
a1e5fd2Comparerichardlau
commented
Jun 4, 2020
MemberAuthor
Landed in a1e5fd2. |
This was referenced Jun 4, 2020
codebytere pushed a commit
that referenced
this pull request
Jun 18, 2020
`common.gypi` is used by `node-gyp` to compile addons. Default values must be provided for variables that may not exist on older versions of Node.js so that older versions of Node.js can be used to compile addons for later versions of Node.js. Add default values for `v8_enable_pointer_compression` and `v8_enable_31bit_smis_on_64bit_arch`. PR-URL: #33688 Refs: #30463 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Signed-off-by: Richard Lau <riclau@uk.ibm.com>
Merged
codebytere pushed a commit
that referenced
this pull request
Jun 30, 2020
`common.gypi` is used by `node-gyp` to compile addons. Default values must be provided for variables that may not exist on older versions of Node.js so that older versions of Node.js can be used to compile addons for later versions of Node.js. Add default values for `v8_enable_pointer_compression` and `v8_enable_31bit_smis_on_64bit_arch`. PR-URL: #33688 Refs: #30463 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Signed-off-by: Richard Lau <riclau@uk.ibm.com>
codebytere pushed a commit
that referenced
this pull request
Jul 9, 2020
`common.gypi` is used by `node-gyp` to compile addons. Default values must be provided for variables that may not exist on older versions of Node.js so that older versions of Node.js can be used to compile addons for later versions of Node.js. Add default values for `v8_enable_pointer_compression` and `v8_enable_31bit_smis_on_64bit_arch`. PR-URL: #33688 Refs: #30463 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Signed-off-by: Richard Lau <riclau@uk.ibm.com>
Merged
3 tasks
This was referenced Apr 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
common.gypiis used bynode-gypto compile addons. Default valuesmust be provided for variables that may not exist on older versions of
Node.js so that older versions of Node.js can be used to compile addons
for later versions of Node.js.
Add default values for
v8_enable_pointer_compressionandv8_enable_31bit_smis_on_64bit_arch.Refs: #30463
Refs: nodejs/node-gyp#1004 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes