Uh oh!
There was an error while loading. Please reload this page.
events: lazy load perf_hooks for EventTarget - #33717
Closed
jasnell wants to merge 2 commits into
Closed
Conversation
nodejs-github-bot
commented
Jun 4, 2020
Collaborator
BridgeAR
approved these changes
Jun 4, 2020
himself65
approved these changes
Jun 4, 2020
jasnell
commented
Jun 4, 2020
MemberAuthor
Please 👍 to fast track |
lundibundi
approved these changes
Jun 4, 2020
juanarbol
approved these changes
Jun 5, 2020
benjamingr
approved these changes
Jun 6, 2020
trivikr
approved these changes
Jun 7, 2020
This comment has been minimized.
This comment has been minimized.
jasnellforce-pushed
the
lazy-load-perf-hooks
branch
from
June 8, 2020 16:27
760fc3c to
a19d755Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This was referenced Jun 9, 2020
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
commented
Jun 16, 2020
Collaborator
jasnell added a commit
that referenced
this pull request
Jun 16, 2020
PR-URL: #33717 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
jasnell
commented
Jun 16, 2020
MemberAuthor
Landed in bc71278 |
18 tasks
codebytere pushed a commit
that referenced
this pull request
Jun 18, 2020
PR-URL: #33717 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
codebytere pushed a commit
that referenced
this pull request
Jun 30, 2020
PR-URL: #33717 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/cc @BridgeAR
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes