Skip to content

tools: update remark-preset-lint-node from 1.15.0 to 1.15.1 - #33727

Closed
Trott wants to merge 0 commit into
nodejs:masterfrom
Trott:update-md-lint-1.15.1
Closed

tools: update remark-preset-lint-node from 1.15.0 to 1.15.1#33727
Trott wants to merge 0 commit into
nodejs:masterfrom
Trott:update-md-lint-1.15.1

Conversation

@Trott

@TrottTrott commented Jun 4, 2020

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jun 4, 2020

@targostargos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 4, 2020
@Trott

Trott commented Jun 4, 2020

Copy link
Copy Markdown
MemberAuthor

(The code here is only run during linting, so GitHub Action results should be sufficient CI. Added author ready label.)

Trott added a commit that referenced this pull request Jun 6, 2020
PR-URL: #33727
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@TrottTrott closed this Jun 6, 2020
@Trott
Trottforce-pushed the update-md-lint-1.15.1 branch from 0c6df5b to 065426cCompareJune 6, 2020 12:50
@Trott

Trott commented Jun 6, 2020

Copy link
Copy Markdown
MemberAuthor

Landed in 065426c

@Trott
Trott deleted the update-md-lint-1.15.1 branch June 6, 2020 12:50
Trott added a commit to Trott/io.js that referenced this pull request Jun 8, 2020
Linting the style guide is failing due to a recent addition in
nodejs#33755 landing before the lint
library being updated in nodejs#33727.
Sorry about the error.
codebytere pushed a commit that referenced this pull request Jun 18, 2020
PR-URL: #33727
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@codebyterecodebytere mentioned this pull request Jun 28, 2020
codebytere pushed a commit that referenced this pull request Jun 30, 2020
PR-URL: #33727
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
codebytere pushed a commit that referenced this pull request Jul 9, 2020
PR-URL: #33727
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@codebyterecodebytere mentioned this pull request Jul 13, 2020
codebytere pushed a commit that referenced this pull request Jul 14, 2020
PR-URL: #33727
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.toolsIssues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Trott@targos@richardlau@nodejs-github-bot