Uh oh!
There was an error while loading. Please reload this page.
doc: Fix the typo in example output in url.md for url.hostname - #33735
doc: Fix the typo in example output in url.md for url.hostname#33735darkrishabh wants to merge 4 commits into
Conversation
DerekNonGeneric
commented
Jun 5, 2020
gireeshpunathil
commented
Jun 5, 2020
@DerekNonGeneric - thanks, and you are right. the @darkrishabh - this change is not correct. At the same time, I guess the doc can be improved to make it more explicit, to avoid confusion. Let me know if you can come up with a sentence. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: James M Snell <jasnell@gmail.com>
Co-authored-by: James M Snell <jasnell@gmail.com>
darkrishabh
commented
Jul 6, 2020
Sorry for picking this up so late, I got involved in some family emergency. I agree with @jasnell and incorporated the change suggested. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
commented
Nov 18, 2020
Landed in 665da27 |
PR-URL: #33735 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #33735 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #33735 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #33735 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #33735 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Currently in the
url.hostname, the replacement example updates the hostname to useexample.com:82but in the comment it's showing the expected output for the operation to be// Prints https://example.com:81/fooIt should be
// Prints https://example.com:82/fooChecklist