Skip to content

doc: specify default encoding in writable.write - #33765

Closed
rexagod wants to merge 2 commits into
nodejs:masterfrom
rexagod:writable-write-enc-docs
Closed

doc: specify default encoding in writable.write#33765
rexagod wants to merge 2 commits into
nodejs:masterfrom
rexagod:writable-write-enc-docs

Conversation

@rexagod

@rexagodrexagod commented Jun 6, 2020

Copy link
Copy Markdown
Member

Refs: #33715

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Jun 6, 2020
Trott
Trott reviewed Jun 6, 2020
View reviewed changes
Comment threaddoc/api/stream.md Outdated
@rexagod@Trott
Update doc/api/stream.md
c6b7f8d
Co-authored-by: Rich Trott <rtrott@gmail.com>
@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 6, 2020
jasnell pushed a commit that referenced this pull request Jun 19, 2020
@rexagod@jasnell
doc: specify default encoding in writable.write
9dcde52
Refs: #33715
PR-URL: #33765
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

jasnell commented Jun 19, 2020

Copy link
Copy Markdown
Member

Landed in 9dcde52

@jasnelljasnell closed this Jun 19, 2020
codebytere pushed a commit that referenced this pull request Jun 22, 2020
@rexagod@codebytere
doc: specify default encoding in writable.write
76fe2a9
Refs: #33715
PR-URL: #33765
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebyterecodebytere mentioned this pull request Jun 28, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 30, 2020
@rexagod@codebytere
doc: specify default encoding in writable.write
8bc1f66
Refs: #33715
PR-URL: #33765
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere pushed a commit that referenced this pull request Jul 10, 2020
@rexagod@codebytere
doc: specify default encoding in writable.write
3789c28
Refs: #33715
PR-URL: #33765
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebyterecodebytere mentioned this pull request Jul 13, 2020
Merged
codebytere pushed a commit that referenced this pull request Jul 14, 2020
@rexagod@codebytere
doc: specify default encoding in writable.write
e5a1ca2
Refs: #33715
PR-URL: #33765
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@TrottTrottTrott approved these changes
@lpincalpincalpinca approved these changes
@trivikrtrivikrtrivikr approved these changes
+1 more reviewer
@MrSlimCoderMrSlimCoderMrSlimCoder approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.streamIssues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@rexagod@jasnell@Trott@lpinca@trivikr@MrSlimCoder@nodejs-github-bot