Skip to content

test: fix invalid regular expressions in case test-trace-exit - #33769

Closed
legendecas wants to merge 1 commit into
nodejs:masterfrom
legendecas:test-trace-exit-regex
Closed

test: fix invalid regular expressions in case test-trace-exit#33769
legendecas wants to merge 1 commit into
nodejs:masterfrom
legendecas:test-trace-exit-regex

Conversation

@legendecas

@legendecaslegendecas commented Jun 6, 2020

Copy link
Copy Markdown
Member

Fixes: #30516 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Jun 6, 2020
@legendecaslegendecas mentioned this pull request Jun 6, 2020
Closed
4 tasks
@targostargos added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 6, 2020
@targos

targos commented Jun 6, 2020

Copy link
Copy Markdown
Member

Simple bug fix in a test... Fast-track?

@nodejs-github-bot

nodejs-github-bot commented Jun 7, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31757/

@legendecas

legendecas commented Jun 9, 2020

Copy link
Copy Markdown
MemberAuthor

Landed in 5590ee0

legendecas added a commit that referenced this pull request Jun 9, 2020
@legendecas
test: fix invalid regular expressions in case test-trace-exit
5590ee0
PR-URL: #33769Fixes: #30516
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@legendecas
legendecas deleted the test-trace-exit-regex branch June 9, 2020 06:55
codebytere pushed a commit that referenced this pull request Jun 18, 2020
@legendecas@codebytere
test: fix invalid regular expressions in case test-trace-exit
b6e3616
PR-URL: #33769Fixes: #30516
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@codebyterecodebytere mentioned this pull request Jun 28, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 30, 2020
@legendecas@codebytere
test: fix invalid regular expressions in case test-trace-exit
5261911
PR-URL: #33769Fixes: #30516
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
codebytere pushed a commit that referenced this pull request Jul 10, 2020
@legendecas@codebytere
test: fix invalid regular expressions in case test-trace-exit
c50bd2f
PR-URL: #33769Fixes: #30516
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@codebyterecodebytere mentioned this pull request Jul 13, 2020
Merged
codebytere pushed a commit that referenced this pull request Jul 14, 2020
@legendecas@codebytere
test: fix invalid regular expressions in case test-trace-exit
8149b72
PR-URL: #33769Fixes: #30516
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@targostargostargos approved these changes
@cjihrigcjihrigcjihrig approved these changes
+1 more reviewer
@lundibundilundibundilundibundi approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fast-trackPRs that do not need to wait for 48 hours to land.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@legendecas@targos@nodejs-github-bot@lpinca@cjihrig@lundibundi