Uh oh!
There was an error while loading. Please reload this page.
doc: fix linting in doc-style-guide.md [master-failing] - #33787
Closed
rexagod wants to merge 1 commit into
Closed
Conversation
Disable lint checks (enable prohibited-strings remark-lint) for doc-style-guide.md:66. This was producing lint errors in builds on master.
rexagod
commented
Jun 7, 2020
MemberAuthor
ping @Trott |
DerekNonGeneric
commented
Jun 7, 2020
Contributor
Fast track? |
rexagod
commented
Jun 7, 2020
MemberAuthor
Trott
commented
Jun 8, 2020
Member
+1 to fast-track. Anyone else? |
3 tasks
danbev
approved these changes
Jun 8, 2020
danbev
commented
Jun 8, 2020
Contributor
Landed in b9739b6. |
danbev pushed a commit
that referenced
this pull request
Jun 8, 2020
Disable lint checks (enable prohibited-strings remark-lint) for doc-style-guide.md:66. This was producing lint errors in builds on master. PR-URL: #33787 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
codebytere pushed a commit
that referenced
this pull request
Jun 18, 2020
Disable lint checks (enable prohibited-strings remark-lint) for doc-style-guide.md:66. This was producing lint errors in builds on master. PR-URL: #33787 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Merged
codebytere pushed a commit
that referenced
this pull request
Jun 30, 2020
Disable lint checks (enable prohibited-strings remark-lint) for doc-style-guide.md:66. This was producing lint errors in builds on master. PR-URL: #33787 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
codebytere pushed a commit
that referenced
this pull request
Jul 9, 2020
Disable lint checks (enable prohibited-strings remark-lint) for doc-style-guide.md:66. This was producing lint errors in builds on master. PR-URL: #33787 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Merged
codebytere pushed a commit
that referenced
this pull request
Jul 14, 2020
Disable lint checks (enable prohibited-strings remark-lint) for doc-style-guide.md:66. This was producing lint errors in builds on master. PR-URL: #33787 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable lint checks (enable prohibited-strings remark-lint) for
doc-style-guide.md:66. This is producing lint errors in builds
on master.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes