Skip to content

Revert "test: stop testing --interpreted-frames-native-stack for s390x" - #33794

Closed
targos wants to merge 1 commit into
nodejs:masterfrom
targos:revert-s390
Closed

Revert "test: stop testing --interpreted-frames-native-stack for s390x"#33794
targos wants to merge 1 commit into
nodejs:masterfrom
targos:revert-s390

Conversation

@targos

@targostargos commented Jun 8, 2020

Copy link
Copy Markdown
Member

Revert "test: stop testing --interpreted-frames-native-stack for s390x"

This reverts commit 38fd93c.

Refs: #33702

@nodejs/platform-s390

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Jun 8, 2020
@targostargos mentioned this pull request Jun 8, 2020
Closed
2 tasks
@nodejs-github-bot

nodejs-github-bot commented Jun 8, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31774/

@richardlaurichardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 8, 2020
This was referenced Jun 9, 2020
Open
Open
targos added a commit that referenced this pull request Jun 12, 2020
@targos
Revert "test: stop testing --interpreted-frames-native-stack for s390x"
76ceaff
This reverts commit 38fd93c.
Refs: #33702
PR-URL: #33794
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@targos

targos commented Jun 12, 2020

Copy link
Copy Markdown
MemberAuthor

Landed in 76ceaff

@targostargos closed this Jun 12, 2020
@targos
targos deleted the revert-s390 branch June 12, 2020 13:49
codebytere pushed a commit that referenced this pull request Jun 18, 2020
@targos@codebytere
Revert "test: stop testing --interpreted-frames-native-stack for s390x"
b8fdde4
This reverts commit 38fd93c.
Refs: #33702
PR-URL: #33794
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@codebyterecodebytere mentioned this pull request Jun 28, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 30, 2020
@targos@codebytere
Revert "test: stop testing --interpreted-frames-native-stack for s390x"
bce2bba
This reverts commit 38fd93c.
Refs: #33702
PR-URL: #33794
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes
@richardlaurichardlaurichardlau approved these changes
@BethGriggsBethGriggsBethGriggs approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@targos@nodejs-github-bot@addaleax@richardlau@BethGriggs