Skip to content

src: remove unused ERR_TRANSFERRING_EXTERNALIZED_SHAREDARRAYBUFFER - #33810

Closed
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:removed-sab-err
Closed

src: remove unused ERR_TRANSFERRING_EXTERNALIZED_SHAREDARRAYBUFFER#33810
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:removed-sab-err

Conversation

@addaleax

@addaleaxaddaleax commented Jun 9, 2020

Copy link
Copy Markdown
Member

Removed in 2bdeb88.

Refs: #30020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@addaleaxaddaleax added errors Issues and PRs related to JavaScript errors originated in Node.js core. dont-land-on-v10.x labels Jun 9, 2020
@nodejs-github-botnodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jun 9, 2020
@addaleaxaddaleax added the worker Issues and PRs related to Worker support. label Jun 9, 2020
@addaleaxaddaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 10, 2020
@nodejs-github-bot

nodejs-github-bot commented Jun 10, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31812/

@nodejs-github-bot

nodejs-github-bot commented Jun 11, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31840/

addaleax added a commit that referenced this pull request Jun 11, 2020
@addaleax
src: remove unused ERR_TRANSFERRING_EXTERNALIZED_SHAREDARRAYBUFFER
c4a33f7
Removed in 2bdeb88.
Refs: #30020
PR-URL: #33810
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@addaleax

addaleax commented Jun 11, 2020

Copy link
Copy Markdown
MemberAuthor

Landed in c4a33f7

@addaleax
addaleax deleted the removed-sab-err branch June 11, 2020 19:52
codebytere pushed a commit that referenced this pull request Jun 18, 2020
@addaleax@codebytere
src: remove unused ERR_TRANSFERRING_EXTERNALIZED_SHAREDARRAYBUFFER
3b71aa8
Removed in 2bdeb88.
Refs: #30020
PR-URL: #33810
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@codebyterecodebytere mentioned this pull request Jun 28, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 30, 2020
@addaleax@codebytere
src: remove unused ERR_TRANSFERRING_EXTERNALIZED_SHAREDARRAYBUFFER
4125996
Removed in 2bdeb88.
Refs: #30020
PR-URL: #33810
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@cjihrigcjihrigcjihrig approved these changes
+1 more reviewer
@devsnekdevsnekdevsnek approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.errorsIssues and PRs related to JavaScript errors originated in Node.js core.workerIssues and PRs related to Worker support.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@addaleax@nodejs-github-bot@jasnell@cjihrig@devsnek