Skip to content

test: temporarily exclude test on arm - #33814

Closed
mhdawson wants to merge 2 commits into
nodejs:masterfrom
mhdawson:excltest2
Closed

test: temporarily exclude test on arm#33814
mhdawson wants to merge 2 commits into
nodejs:masterfrom
mhdawson:excltest2

Conversation

@mhdawson

@mhdawsonmhdawson commented Jun 9, 2020•
edited
Loading

Copy link
Copy Markdown
Member

Temporarily excluded until #33796 is resolved.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@mhdawson
test: temporarily exclude test on arm
e435084
Refs: nodejs#33796
Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com>
@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Jun 9, 2020
@mhdawson

mhdawson commented Jun 9, 2020

Copy link
Copy Markdown
MemberAuthor

CI run: https://ci.nodejs.org/job/node-test-pull-request/31802/

@mhdawsonmhdawson closed this Jun 9, 2020
addaleax
addaleax approved these changes Jun 9, 2020
View reviewed changes

@addaleaxaddaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is not inherently broken on the platform – it should pass on ARM. Let’s mark it flaky instead of just not running it.

Comment threadtest/parallel/parallel.status Outdated
@mhdawson

mhdawson commented Jun 9, 2020

Copy link
Copy Markdown
MemberAuthor

Would like to ask that this is fast-tracked if it gets CI to green.

@addaleaxaddaleax reopened this Jun 9, 2020
@mhdawsonmhdawson added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 9, 2020
@mhdawson@addaleax
Update test/parallel/parallel.status
56c95c4
Co-authored-by: Anna Henningsen <github@addaleax.net>
@nodejs-github-bot

nodejs-github-bot commented Jun 9, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31803/

@mhdawson

mhdawson commented Jun 9, 2020

Copy link
Copy Markdown
MemberAuthor

Updated CI run: https://ci.nodejs.org/job/node-test-pull-request/31803/

@mhdawson

mhdawson commented Jun 9, 2020

Copy link
Copy Markdown
MemberAuthor

CI run was green landing.

mhdawson added a commit that referenced this pull request Jun 9, 2020
@mhdawson
test: temporarily exclude test on arm
502f53f
Refs: #33796
Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com>
PR-URL: #33814
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@mhdawson

mhdawson commented Jun 9, 2020

Copy link
Copy Markdown
MemberAuthor

Landed in 502f53f

@mhdawsonmhdawson closed this Jun 9, 2020
codebytere pushed a commit that referenced this pull request Jun 18, 2020
@mhdawson@codebytere
test: temporarily exclude test on arm
e3a5332
Refs: #33796
Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com>
PR-URL: #33814
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@codebyterecodebytere mentioned this pull request Jun 28, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 30, 2020
@mhdawson@codebytere
test: temporarily exclude test on arm
4bb0670
Refs: #33796
Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com>
PR-URL: #33814
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
codebytere pushed a commit that referenced this pull request Jul 10, 2020
@mhdawson@codebytere
test: temporarily exclude test on arm
b5113d0
Refs: #33796
Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com>
PR-URL: #33814
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@codebyterecodebytere mentioned this pull request Jul 13, 2020
Merged
codebytere pushed a commit that referenced this pull request Jul 14, 2020
@mhdawson@codebytere
test: temporarily exclude test on arm
ce0ab70
Refs: #33796
Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com>
PR-URL: #33814
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@mhdawson
mhdawson deleted the excltest2 branch September 14, 2020 21:19
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes
@lpincalpincalpinca approved these changes
@richardlaurichardlaurichardlau approved these changes

Assignees

No one assigned

Labels

fast-trackPRs that do not need to wait for 48 hours to land.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mhdawson@nodejs-github-bot@addaleax@lpinca@richardlau