Skip to content

src: avoid unnecessary ToLocalChecked calls - #33824

Closed
danbev wants to merge 2 commits into
nodejs:masterfrom
danbev:string_bytes_tolocalchecked
Closed

src: avoid unnecessary ToLocalChecked calls#33824
danbev wants to merge 2 commits into
nodejs:masterfrom
danbev:string_bytes_tolocalchecked

Conversation

@danbev

@danbevdanbev commented Jun 10, 2020

Copy link
Copy Markdown
Contributor

This commit removes two unnecessary ToLocalChecked calls in
StringBytes::Encode.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@danbev
src: avoid unnecessary ToLocalChecked calls
db81fc8
This commit removes two unnecessary ToLocalChecked calls in
StringBytes::Encode.
@nodejs-github-botnodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. labels Jun 10, 2020
@nodejs-github-bot

nodejs-github-bot commented Jun 10, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31819/

@danbevdanbev added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 15, 2020
danbev added a commit that referenced this pull request Jun 15, 2020
@danbev
src: avoid unnecessary ToLocalChecked calls
8f7211a
This commit removes two unnecessary ToLocalChecked calls in
StringBytes::Encode.
PR-URL: #33824
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
danbev added a commit that referenced this pull request Jun 15, 2020
@danbev
src: remove unused vector include in string_bytes
74d8011
PR-URL: #33824
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
@danbev

danbev commented Jun 15, 2020

Copy link
Copy Markdown
ContributorAuthor

Landed in 8f7211a, and 74d8011.

@danbevdanbev closed this Jun 15, 2020
@danbev
danbev deleted the string_bytes_tolocalchecked branch June 15, 2020 03:59
codebytere pushed a commit that referenced this pull request Jun 18, 2020
@danbev@codebytere
src: avoid unnecessary ToLocalChecked calls
fb2b0a0
This commit removes two unnecessary ToLocalChecked calls in
StringBytes::Encode.
PR-URL: #33824
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
codebytere pushed a commit that referenced this pull request Jun 18, 2020
@danbev@codebytere
src: remove unused vector include in string_bytes
dfa0ee1
PR-URL: #33824
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
@codebyterecodebytere mentioned this pull request Jun 28, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 30, 2020
@danbev@codebytere
src: avoid unnecessary ToLocalChecked calls
8ea4c37
This commit removes two unnecessary ToLocalChecked calls in
StringBytes::Encode.
PR-URL: #33824
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
codebytere pushed a commit that referenced this pull request Jun 30, 2020
@danbev@codebytere
src: remove unused vector include in string_bytes
7f67c2c
PR-URL: #33824
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
codebytere pushed a commit that referenced this pull request Jul 10, 2020
@danbev@codebytere
src: avoid unnecessary ToLocalChecked calls
ec2452c
This commit removes two unnecessary ToLocalChecked calls in
StringBytes::Encode.
PR-URL: #33824
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
codebytere pushed a commit that referenced this pull request Jul 10, 2020
@danbev@codebytere
src: remove unused vector include in string_bytes
185657d
PR-URL: #33824
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
@codebyterecodebytere mentioned this pull request Jul 13, 2020
Merged
codebytere pushed a commit that referenced this pull request Jul 14, 2020
@danbev@codebytere
src: avoid unnecessary ToLocalChecked calls
53f4295
This commit removes two unnecessary ToLocalChecked calls in
StringBytes::Encode.
PR-URL: #33824
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
codebytere pushed a commit that referenced this pull request Jul 14, 2020
@danbev@codebytere
src: remove unused vector include in string_bytes
70d46ab
PR-URL: #33824
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes
@cjihrigcjihrigcjihrig approved these changes
@richardlaurichardlaurichardlau approved these changes
+1 more reviewer
@devnexendevnexendevnexen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.bufferIssues and PRs related to the buffer subsystem.c++Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@danbev@nodejs-github-bot@addaleax@cjihrig@devnexen@richardlau