Skip to content

tools: remove unused vector include in mkcodecache - #33828

Closed
danbev wants to merge 1 commit into
nodejs:masterfrom
danbev:mkcodecache_vector
Closed

tools: remove unused vector include in mkcodecache#33828
danbev wants to merge 1 commit into
nodejs:masterfrom
danbev:mkcodecache_vector

Conversation

@danbev

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jun 10, 2020
@danbevdanbev changed the title tools: remove unused vector include in mkdcodecachetools: remove unused vector include in mkcodecacheJun 10, 2020
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@addaleaxaddaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 11, 2020
danbev added a commit that referenced this pull request Jun 15, 2020
PR-URL: #33828
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@danbev

Copy link
Copy Markdown
ContributorAuthor

Landed in aa40bad.

@danbevdanbev closed this Jun 15, 2020
@danbev
danbev deleted the mkcodecache_vector branch June 15, 2020 04:04
codebytere pushed a commit that referenced this pull request Jun 18, 2020
PR-URL: #33828
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@codebyterecodebytere mentioned this pull request Jun 28, 2020
codebytere pushed a commit that referenced this pull request Jun 30, 2020
PR-URL: #33828
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
codebytere pushed a commit that referenced this pull request Jul 10, 2020
PR-URL: #33828
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@codebyterecodebytere mentioned this pull request Jul 13, 2020
codebytere pushed a commit that referenced this pull request Jul 14, 2020
PR-URL: #33828
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.toolsIssues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@danbev@nodejs-github-bot@addaleax@cjihrig@richardlau