Skip to content

doc: warn that tls.connect() doesn't set SNI#33855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mildsunrise wants to merge 2 commits into from
Closed

doc: warn that tls.connect() doesn't set SNI #33855

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ae5aee
doc: warn that tls.connect() doesn't set SNI
mildsunrise Jun 12, 2020
6cea534
Update doc/api/tls.md
mildsunrise Jun 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions doc/api/tls.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -1402,6 +1402,12 @@ The `callback` function, if specified, will be added as a listener for the

`tls.connect()` returns a [`tls.TLSSocket`][] object.

Unlike the `https` API, `tls.connect()` does not enable the
SNI (Server Name Indication) extension by default, which may cause some
servers to return an incorrect certificate or reject the connection
altogether. To enable SNI, set the `servername` option in addition
to `host`.

The following illustrates a client for the echo server example from
[`tls.createServer()`][]:

Expand Down