Uh oh!
There was an error while loading. Please reload this page.
esm: clarify conditional exports prose - #33886
Closed
DerekNonGeneric wants to merge 1 commit into
Closed
Conversation
guybedford
approved these changes
Jun 15, 2020
guybedford
left a comment
Contributor
There was a problem hiding this comment.
Nice, thanks for the PR.
Uh oh!
There was an error while loading. Please reload this page.
rexagod
reviewed
Jun 20, 2020
Uh oh!
There was an error while loading. Please reload this page.
rexagod
approved these changes
Jun 20, 2020
benjamingr
approved these changes
Jun 21, 2020
addaleax
approved these changes
Jun 25, 2020
addaleax
left a comment
Member
There was a problem hiding this comment.
@DerekNonGeneric Could you rebase this to resolve conflicts?
This commit clarifies the behavior of a couple aspects of conditional exports that may have been difficult to grasp from the prose alone.
DerekNonGeneric
commented
Jun 25, 2020
ContributorAuthor
@addaleax, sure thing; done! |
jasnell
approved these changes
Jun 26, 2020
jasnell pushed a commit
that referenced
this pull request
Jul 3, 2020
This commit clarifies the behavior of a couple aspects of conditional exports that may have been difficult to grasp from the prose alone. PR-URL: #33886 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
commented
Jul 3, 2020
Member
Landed in db3b209 |
MylesBorins pushed a commit
that referenced
this pull request
Jul 14, 2020
This commit clarifies the behavior of a couple aspects of conditional exports that may have been difficult to grasp from the prose alone. PR-URL: #33886 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins pushed a commit
that referenced
this pull request
Jul 16, 2020
This commit clarifies the behavior of a couple aspects of conditional exports that may have been difficult to grasp from the prose alone. PR-URL: #33886 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit
that referenced
this pull request
Sep 22, 2020
This commit clarifies the behavior of a couple aspects of conditional exports that may have been difficult to grasp from the prose alone. PR-URL: #33886 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit clarifies the behavior of a couple aspects of
conditional exports that may have been difficult to grasp
from the prose alone.
Checklist
/cc @nodejs/modules @nodejs/documentation