Uh oh!
There was an error while loading. Please reload this page.
win,msi: use x64 node executable when cross-compiling for arm64 - #34009
win,msi: use x64 node executable when cross-compiling for arm64#34009dennisameling wants to merge 5 commits into
Conversation
joaocgreis
left a comment
There was a problem hiding this comment.
@dennisameling again, thanks for pushing this forward!
The general approach looks good, but there are some things that need to change before this can land.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
dennisameling
commented
Aug 8, 2020
@joaocgreis Apologies for the late reply. I've applied your suggestions, so we should be good to go now for this PR 😊 |
nodejs-github-bot
commented
Aug 11, 2020
joaocgreis
left a comment
There was a problem hiding this comment.
@dennisameling again, thanks for pushing this forward!
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: João Reis <reis@janeasystems.com>
nodejs-github-bot
commented
Aug 11, 2020
(Edit: commented in the wrong tab). |
joaocgreis
commented
Aug 19, 2020
Landed in 03293aa Thanks @dennisameling! |
Builds further on #33689
The last step to successfully create MSI installers for arm64 on a x64 host is to run the
license2rtfscript on the x64 host using a x64 Node executable. Based on @joaocgreis's comment in #33689 (review) I came up with some logic invcbuild.batwhich downloads the latest x64 Node executable if it's not present on the machine yet.A variable called
%x64_node_exe%can be passed by your CI pipeline so that the build machines don't have to download the x64 executable all the time.IMPORTANT: when building an MSI for ARM64, WIX 3.14 or higher is required, as that version includes support for ARM64.
How to test
vcbuild.bat release msi arm64Before applying this PR, the process fails with
Failed to generate license.rtf(because the generatednode.exeis for the arm64 architecture and therefore can't run on the x64 host).After applying this PR, the process finishes successfully.
Refs: #25998
Refs: #32582
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes