Uh oh!
There was an error while loading. Please reload this page.
quic: update deps for quic draft 29 - #34033
Closed
jasnell wants to merge 13 commits into
Closed
Conversation
…a4e2e9ea568 Original Commit Message: Some cleanup for the main QUIC changes Try to reduce unneeded whitespace changes and wrap new code to 80 columns. Reword documentation to attempt to improve clarity. Add some more sanity checks and clarifying comments to the code. Update referenced I-D versions.
…2f2487bf8b3 Original Commit Message: Prevent KeyUpdate for QUIC QUIC does not use the TLS KeyUpdate message/mechanism, and indeed it is an error to generate or receive such a message. Add the necessary checks (noting that the check for receipt should be redundant since SSL_provide_quic_data() is the only way to provide input to the TLS layer for a QUIC connection).
…f482e392456 Original Commit Message: Test KeyUpdate rejection For now, just test that we don't generate any, since we don't really expose the mechanics for encrypting one and the QUIC API is not integrated into the TLSProxy setup.
…31d18d7bda9 Original Commit Message: Fix out-of-bounds read when TLS msg is split up into multiple chunks Previously, SSL_provide_quic_data tried to handle this kind of situation, but it failed when the length of input data is less than SSL3_HM_HEADER_LENGTH. If that happens, the code might get wrong message length by reading value from out-of-bounds region.
jasnell
marked this pull request as draft
June 23, 2020 18:56
addaleax
approved these changes
Jun 23, 2020
jasnellforce-pushed
the
update-quic-deps-20200622
branch
from
June 23, 2020 22:00
2b5d55c to
86a1b21CompareThe ngtcp2 update uses a gcc builtin that is not available under _MSC_VER. This floats a patch to fix it. Upstream PR: ngtcp2/ngtcp2#247
jasnellforce-pushed
the
update-quic-deps-20200622
branch
from
June 23, 2020 23:37
a1801fb to
594844fComparejasnell
marked this pull request as ready for review
June 24, 2020 00:02
jasnell
commented
Jun 24, 2020
MemberAuthor
Still a couple of failures in test-quic-ipv6only to investigate but overall moving in the right direction... https://ci.nodejs.org/job/node-test-commit/39233/ |
This comment has been minimized.
This comment has been minimized.
13 tasks
gengjiawen
commented
Jun 24, 2020
Member
Build looks failed. |
nodejs-github-bot
commented
Jun 24, 2020
Collaborator
jasnell
commented
Jun 24, 2020
MemberAuthor
Yep, fixing the regular without |
gengjiawen
approved these changes
Jun 24, 2020
nodejs-github-bot
commented
Jun 24, 2020
Collaborator
jasnellforce-pushed
the
update-quic-deps-20200622
branch
from
June 24, 2020 03:29
55c1300 to
752e807Comparedanbev
approved these changes
Jun 24, 2020
Uh oh!
There was an error while loading. Please reload this page.
2 tasks
jasnellforce-pushed
the
update-quic-deps-20200622
branch
2 times, most recently
from
June 24, 2020 04:10
f49d13b to
8448815Comparejasnell added a commit
that referenced
this pull request
Jun 24, 2020
PR-URL: #34033 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
jasnell added a commit
that referenced
this pull request
Jun 24, 2020
PR-URL: #34033 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
jasnell added a commit
that referenced
this pull request
Jun 24, 2020
The dual stack support is currently broken as the QuicSocket endpoints are not properly accounting for all cases. Needs to be investigated further. PR-URL: #34033 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
jasnell added a commit
that referenced
this pull request
Jun 24, 2020
PR-URL: #34033 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
jasnell
commented
Jun 24, 2020
MemberAuthor
Landed in a2b1b92...7816e5f |
This was referenced Jun 25, 2020
This was referenced Jun 28, 2020
MylesBorins pushed a commit
to MylesBorins/node
that referenced
this pull request
Dec 15, 2020
PR-URL: nodejs#34033 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Closed
MylesBorins pushed a commit
that referenced
this pull request
Dec 17, 2020
PR-URL: #34033 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> PR-URL: #36520 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>
targos pushed a commit
that referenced
this pull request
Dec 21, 2020
PR-URL: #34033 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> PR-URL: #36520 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update dependencies (ngtcp2, nghttp3, and akamai openssl+quic) for latest 29... update impl accordingly. There are likely additional bits that needs to be changed.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes