Skip to content

quic: minor cleanups in quic_buffer - #34087

Closed
jasnell wants to merge 2 commits into
nodejs:masterfrom
jasnell:quic-cleanups
Closed

quic: minor cleanups in quic_buffer#34087
jasnell wants to merge 2 commits into
nodejs:masterfrom
jasnell:quic-cleanups

Conversation

@jasnell

@jasnelljasnell commented Jun 27, 2020

Copy link
Copy Markdown
Member

Minor additional cleanup to QuicBuffer

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@jasnelljasnell added the quic Issues and PRs related to the QUIC implementation / HTTP/3. label Jun 27, 2020
@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Jun 27, 2020
@jasnell

jasnell commented Jun 27, 2020

Copy link
Copy Markdown
MemberAuthor

QUIC CI: https://ci.nodejs.org/job/node-test-commit/39326/

addaleax
addaleax approved these changes Jun 27, 2020
View reviewed changes
Comment threadsrc/quic/node_quic_buffer.cc Outdated
@nodejs-github-bot

nodejs-github-bot commented Jun 30, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32157/

@jasnell

jasnell commented Jun 30, 2020

Copy link
Copy Markdown
MemberAuthor

QUIC CI: https://ci.nodejs.org/job/node-test-commit/39382/

jasnell added a commit that referenced this pull request Jun 30, 2020
@jasnell
quic: minor cleanups in quic_buffer
204f20f
PR-URL: #34087
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
@jasnell

jasnell commented Jun 30, 2020

Copy link
Copy Markdown
MemberAuthor

Landed in 204f20f

@jasnelljasnell closed this Jun 30, 2020
@MylesBorins

MylesBorins commented Jul 14, 2020

Copy link
Copy Markdown
Contributor

Marked as "backport-requested" because I do not believe quic is on 14.x yet. Should we change the label to "dont-land"?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes
+1 more reviewer
@devnexendevnexendevnexen approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.lib / srcIssues and PRs related to general changes in the lib or src directory.quicIssues and PRs related to the QUIC implementation / HTTP/3.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jasnell@nodejs-github-bot@MylesBorins@addaleax@devnexen@targos