Uh oh!
There was an error while loading. Please reload this page.
doc: clarify ambiguous rdev description - #34094
Merged
Merged
Conversation
Trott
commented
Jun 29, 2020
MemberAuthor
@nodejs/documentation |
addaleax
approved these changes
Jun 29, 2020
Trott
commented
Jun 30, 2020
MemberAuthor
@nodejs/fs |
Trott
commented
Jul 1, 2020
MemberAuthor
@nodejs/collaborators Hoping this is not particularly controversial. Needs a second review. |
ryzokuken
approved these changes
Jul 1, 2020
Trott
commented
Jul 1, 2020
MemberAuthor
Landed in 584fc7e |
MylesBorins pushed a commit
that referenced
this pull request
Jul 14, 2020
Replace "is considered 'special'" with "represents a device". The latter is more clear and is derived from the stat() man page. The former is also derived from the man page, but is ambiguous because: * "considered" introduces doubt. Is it, or isn't it? * "special" is never defined. "represents a device" communicates more meaning. * "special" is in scare-quotes, introducing more doubt as to what exactly it means. Refs: https://man7.org/linux/man-pages/man2/fstat.2.html PR-URL: #34094 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Merged
MylesBorins pushed a commit
that referenced
this pull request
Jul 16, 2020
Replace "is considered 'special'" with "represents a device". The latter is more clear and is derived from the stat() man page. The former is also derived from the man page, but is ambiguous because: * "considered" introduces doubt. Is it, or isn't it? * "special" is never defined. "represents a device" communicates more meaning. * "special" is in scare-quotes, introducing more doubt as to what exactly it means. Refs: https://man7.org/linux/man-pages/man2/fstat.2.html PR-URL: #34094 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
addaleax pushed a commit
that referenced
this pull request
Sep 22, 2020
Replace "is considered 'special'" with "represents a device". The latter is more clear and is derived from the stat() man page. The former is also derived from the man page, but is ambiguous because: * "considered" introduces doubt. Is it, or isn't it? * "special" is never defined. "represents a device" communicates more meaning. * "special" is in scare-quotes, introducing more doubt as to what exactly it means. Refs: https://man7.org/linux/man-pages/man2/fstat.2.html PR-URL: #34094 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace "is considered 'special'" with "represents a device". The latter
is more clear and is derived from the stat() man page. The former is
also derived from the man page, but is ambiguous because:
meaning.
exactly it means.
Refs: https://man7.org/linux/man-pages/man2/fstat.2.html
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes