Uh oh!
There was an error while loading. Please reload this page.
[v12.x backport] http: fix incorrect headersTimeout measurement - #34131
Closed
Flarna wants to merge 1 commit into
Closed
[v12.x backport] http: fix incorrect headersTimeout measurement #34131Flarna wants to merge 1 commit into
Flarna wants to merge 1 commit into
Conversation
For keep-alive connections, the headersTimeout may fire during subsequent request because the measurement was reset after a request and not before a request. PR-URL: nodejs#32329Fixes: nodejs#27363 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
4 tasks
nodejs-github-bot
commented
Jun 30, 2020
Collaborator
nodejs-github-bot
commented
Jun 30, 2020
Collaborator
codebytere
approved these changes
Jul 12, 2020
codebytereforce-pushed
the
v12.x-staging
branch
2 times, most recently
from
July 21, 2020 18:34
b64963e to
3b1d9b3Comparedanielleadams
approved these changes
Aug 4, 2020
MylesBorins pushed a commit
that referenced
this pull request
Aug 18, 2020
For keep-alive connections, the headersTimeout may fire during subsequent request because the measurement was reset after a request and not before a request. Backport-PR-URL: #34131 PR-URL: #32329Fixes: #27363 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins
commented
Aug 18, 2020
Contributor
landed in 11a87ed |
1 task
jimmy54 pushed a commit
to jimmy54/nodejs-mobile
that referenced
this pull request
Dec 31, 2025
For keep-alive connections, the headersTimeout may fire during subsequent request because the measurement was reset after a request and not before a request. Backport-PR-URL: nodejs/node#34131 PR-URL: nodejs/node#32329Fixes: nodejs/node#27363 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For keep-alive connections, the headersTimeout may fire during
subsequent request because the measurement was reset after
a request and not before a request.
PR-URL: #32329
Fixes: #27363
Reviewed-By: Anna Henningsen anna@addaleax.net
Reviewed-By: Matteo Collina matteo.collina@gmail.com
fyi @OrKoN
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes