Uh oh!
There was an error while loading. Please reload this page.
quic: multiple cleanups - #34137
Closed
jasnell wants to merge 8 commits into
Closed
Conversation
addaleax
approved these changes
Jun 30, 2020
Uh oh!
There was an error while loading. Please reload this page.
Ignore subsequent calls to set_final_size unless the new size is more than the previous, in which case, we have us a bug.
Use a single callback function for both
devnexen
approved these changes
Jun 30, 2020
nodejs-github-bot
commented
Jun 30, 2020
Collaborator
They introduce a significant performance bottleneck at the moment.
nodejs-github-bot
commented
Jun 30, 2020
Collaborator
jasnell
commented
Jun 30, 2020
MemberAuthor
jasnell
marked this pull request as ready for review
June 30, 2020 21:59
jasnell
commented
Jul 1, 2020
MemberAuthor
Landing under accelerated landing rules as part of the CODEOWNERS/No-time-limit experiment. CI has passed, @nodejs/quic has signed off. PR only touches the experimental QUIC impl. |
jasnell added a commit
that referenced
this pull request
Jul 1, 2020
PR-URL: #34137 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com>
jasnell added a commit
that referenced
this pull request
Jul 1, 2020
PR-URL: #34137 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com>
jasnell added a commit
that referenced
this pull request
Jul 1, 2020
Ignore subsequent calls to set_final_size unless the new size is more than the previous, in which case, we have us a bug. PR-URL: #34137 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com>
jasnell added a commit
that referenced
this pull request
Jul 1, 2020
Use a single callback function for both PR-URL: #34137 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com>
jasnell added a commit
that referenced
this pull request
Jul 1, 2020
PR-URL: #34137 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com>
jasnell added a commit
that referenced
this pull request
Jul 1, 2020
PR-URL: #34137 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com>
jasnell added a commit
that referenced
this pull request
Jul 1, 2020
They introduce a significant performance bottleneck at the moment. PR-URL: #34137 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com>
jasnell added a commit
that referenced
this pull request
Jul 1, 2020
PR-URL: #34137 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com>
jasnell
commented
Jul 1, 2020
MemberAuthor
Landed in e20beaf...31d6d9d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiple ongoing cleanups and starting to refactor impl. There's a lot more here to work on, but this is a start.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes