Skip to content

test: add regression test for C++-created Buffer transfer - #34140

Closed
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:worker-transfer-buffer-from-crypto
Closed

test: add regression test for C++-created Buffer transfer#34140
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:worker-transfer-buffer-from-crypto

Conversation

@addaleax

@addaleaxaddaleax commented Jun 30, 2020

Copy link
Copy Markdown
Member

Add a test for a regression that occurs when transferring some
Buffer objects that were created from C++ to a parent thread.

Fixes: #34126

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@addaleax
test: add regression test for C++-created Buffer transfer
0239467
Add a test for a regression that occurs when transferring some
`Buffer` objects that were created from C++ to a parent thread.
Fixes: nodejs#34126
@addaleax
addaleaxforce-pushed the worker-transfer-buffer-from-crypto branch from a2f8b87 to 0239467CompareJune 30, 2020 18:21
@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Jun 30, 2020
@nodejs-github-bot

nodejs-github-bot commented Jun 30, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32164/

@addaleax

addaleax commented Jul 7, 2020

Copy link
Copy Markdown
MemberAuthor

Landed in cb67be7

addaleax added a commit that referenced this pull request Jul 7, 2020
@addaleax
test: add regression test for C++-created Buffer transfer
cb67be7
Add a test for a regression that occurs when transferring some
`Buffer` objects that were created from C++ to a parent thread.
Fixes: #34126
PR-URL: #34140
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
@addaleaxaddaleax closed this Jul 7, 2020
@addaleax
addaleax deleted the worker-transfer-buffer-from-crypto branch July 7, 2020 21:42
MylesBorins pushed a commit that referenced this pull request Jul 14, 2020
@addaleax@MylesBorins
test: add regression test for C++-created Buffer transfer
27f47a5
Add a test for a regression that occurs when transferring some
`Buffer` objects that were created from C++ to a parent thread.
Fixes: #34126
PR-URL: #34140
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
@MylesBorinsMylesBorins mentioned this pull request Jul 14, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Jul 16, 2020
@addaleax@MylesBorins
test: add regression test for C++-created Buffer transfer
a38219f
Add a test for a regression that occurs when transferring some
`Buffer` objects that were created from C++ to a parent thread.
Fixes: #34126
PR-URL: #34140
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
addaleax added a commit that referenced this pull request Sep 22, 2020
@addaleax
test: add regression test for C++-created Buffer transfer
b7ae73b
Add a test for a regression that occurs when transferring some
`Buffer` objects that were created from C++ to a parent thread.
Fixes: #34126
PR-URL: #34140
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
@codebyterecodebytere mentioned this pull request Sep 28, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FlarnaFlarnaFlarna approved these changes

Assignees

No one assigned

Labels

testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SEGFAULT on Node Fermium

3 participants

@addaleax@nodejs-github-bot@Flarna