Uh oh!
There was an error while loading. Please reload this page.
doc: remove parenthetical \r\n comment in http and http2 docs - #34178
Merged
Conversation
jasnell
approved these changes
Jul 3, 2020
MrHeer
approved these changes
Jul 4, 2020
Trott
commented
Jul 4, 2020
MemberAuthor
Landed in 56dbe46 |
MylesBorins pushed a commit
that referenced
this pull request
Jul 14, 2020
The explanation that the HTTP requests include `\r\n` is true but not important or relevant in these two specific contexts. PR-URL: #34178 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Merged
MylesBorins pushed a commit
that referenced
this pull request
Jul 16, 2020
The explanation that the HTTP requests include `\r\n` is true but not important or relevant in these two specific contexts. PR-URL: #34178 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
addaleax pushed a commit
that referenced
this pull request
Sep 22, 2020
The explanation that the HTTP requests include `\r\n` is true but not important or relevant in these two specific contexts. PR-URL: #34178 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The explanation that the HTTP requests include
\r\nis true but notimportant or relevant in these two specific contexts.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes