Skip to content

doc: specify how fs.WriteStream/ReadStreams are created - #34188

Closed
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:alternative-for-33841
Closed

doc: specify how fs.WriteStream/ReadStreams are created#34188
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:alternative-for-33841

Conversation

@jasnell

@jasnelljasnell commented Jul 3, 2020

Copy link
Copy Markdown
Member

Alternative to #33841 (which seems to have stalled out over some objections). This provides an alternative that is hopefully more acceptable.

/cc @addaleax

Co-authored-by: zombieleet zombieleetnca@gmail.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Jul 3, 2020
@jasnell@zombieleet
doc: specify how fs.WriteStream/ReadStreams are created
6b2b886
Alternative to nodejs#33841
Co-authored-by: zombieleet <zombieleetnca@gmail.com>
@jasnell
jasnellforce-pushed the alternative-for-33841 branch from c61025e to 6b2b886CompareJuly 3, 2020 20:29
@jasnelljasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 3, 2020
jasnell added a commit that referenced this pull request Jul 5, 2020
@jasnell
doc: specify how fs.WriteStream/ReadStreams are created
e7dadd3
Alternative to #33841
Co-authored-by: zombieleet <zombieleetnca@gmail.com>
PR-URL: #34188
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@jasnell

jasnell commented Jul 5, 2020

Copy link
Copy Markdown
MemberAuthor

Landed in e7dadd3

@jasnelljasnell closed this Jul 5, 2020
MylesBorins pushed a commit that referenced this pull request Jul 14, 2020
@jasnell@MylesBorins
doc: specify how fs.WriteStream/ReadStreams are created
c2964b7
Alternative to #33841
Co-authored-by: zombieleet <zombieleetnca@gmail.com>
PR-URL: #34188
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Jul 14, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Jul 16, 2020
@jasnell@MylesBorins
doc: specify how fs.WriteStream/ReadStreams are created
938de33
Alternative to #33841
Co-authored-by: zombieleet <zombieleetnca@gmail.com>
PR-URL: #34188
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 27, 2020
@jasnell@addaleax
doc: specify how fs.WriteStream/ReadStreams are created
a3d18c0
Alternative to #33841
Co-authored-by: zombieleet <zombieleetnca@gmail.com>
PR-URL: #34188
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 28, 2020
@jasnell@addaleax
doc: specify how fs.WriteStream/ReadStreams are created
cef9921
Alternative to #33841
Co-authored-by: zombieleet <zombieleetnca@gmail.com>
PR-URL: #34188
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@codebyterecodebytere mentioned this pull request Sep 28, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes
@lpincalpincalpinca approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.fsIssues and PRs related to the fs subsystem / file system.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jasnell@addaleax@lpinca@nodejs-github-bot