Uh oh!
There was an error while loading. Please reload this page.
src: fix unused namespace member - #34212
Closed
branisha wants to merge 1 commit into
Closed
Conversation
C++ linter fails because of unused ArrayBuffer namespace member
addaleax
commented
Jul 5, 2020
Member
Collaborators, please 👍 this comment to approve fast-tracking |
nodejs-github-bot
commented
Jul 5, 2020
Collaborator
jasnell
approved these changes
Jul 5, 2020
richardlau
approved these changes
Jul 6, 2020
gengjiawen
approved these changes
Jul 6, 2020
gireeshpunathil
approved these changes
Jul 6, 2020
gireeshpunathil pushed a commit
that referenced
this pull request
Jul 6, 2020
C++ linter fails because of unused ArrayBuffer namespace member PR-URL: #34212 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
gireeshpunathil
commented
Jul 6, 2020
Member
landed in 82c435d , thanks for the contribution! |
MylesBorins pushed a commit
that referenced
this pull request
Jul 14, 2020
C++ linter fails because of unused ArrayBuffer namespace member PR-URL: #34212 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Merged
MylesBorins pushed a commit
that referenced
this pull request
Jul 16, 2020
C++ linter fails because of unused ArrayBuffer namespace member PR-URL: #34212 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
addaleax pushed a commit
that referenced
this pull request
Sep 22, 2020
C++ linter fails because of unused ArrayBuffer namespace member PR-URL: #34212 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make -j4 testfails because of C++ linter saying:Reverting commit ee3243f removes problem.
After removing
using v8::ArrayBuffer;build passes.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes