Skip to content

doc: add note about multiple sync events and once - #34220

Closed
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:doc-for-32431
Closed

doc: add note about multiple sync events and once#34220
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:doc-for-32431

Conversation

@jasnell

@jasnelljasnell commented Jul 6, 2020

Copy link
Copy Markdown
Member

Fixes: #32431

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. events Issues and PRs related to the events subsystem / EventEmitter. labels Jul 6, 2020
lpinca
lpinca reviewed Jul 6, 2020
View reviewed changes
Comment threaddoc/api/events.md Outdated
jasnell
jasnell commented Jul 7, 2020
View reviewed changes
Comment threaddoc/api/events.md Outdated
jasnell
jasnell commented Jul 7, 2020
View reviewed changes
Comment threaddoc/api/events.md Outdated
@jasnelljasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 7, 2020
jasnell added a commit that referenced this pull request Jul 9, 2020
@jasnell
doc: add note about multiple sync events and once
62bdb7e
Fixes: #32431
PR-URL: #34220
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@jasnell

jasnell commented Jul 9, 2020

Copy link
Copy Markdown
MemberAuthor

Landed in 62bdb7e

@jasnelljasnell closed this Jul 9, 2020
MylesBorins pushed a commit that referenced this pull request Jul 14, 2020
@jasnell@MylesBorins
doc: add note about multiple sync events and once
6d12515
Fixes: #32431
PR-URL: #34220
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Jul 14, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Jul 16, 2020
@jasnell@MylesBorins
doc: add note about multiple sync events and once
431bfe1
Fixes: #32431
PR-URL: #34220
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
codebytere pushed a commit that referenced this pull request Sep 27, 2020
@jasnell@codebytere
doc: add note about multiple sync events and once
3f2a696
Fixes: #32431
PR-URL: #34220
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 28, 2020
@jasnell@addaleax
doc: add note about multiple sync events and once
831328b
Fixes: #32431
PR-URL: #34220
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@codebyterecodebytere mentioned this pull request Sep 28, 2020
Merged
@Renegade334Renegade334 mentioned this pull request Jan 28, 2026
Merged
nodejs-github-bot pushed a commit that referenced this pull request Feb 12, 2026
@Renegade334
doc: clarify async caveats for events.once()
3b69757
PR-URL: #61572
Refs: #34220
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request Feb 19, 2026
@Renegade334@aduh95
doc: clarify async caveats for events.once()
db610b9
PR-URL: #61572
Refs: #34220
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request Apr 4, 2026
@Renegade334@aduh95
doc: clarify async caveats for events.once()
836e439
PR-URL: #61572
Refs: #34220
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request Apr 5, 2026
@Renegade334@aduh95
doc: clarify async caveats for events.once()
ade646a
PR-URL: #61572
Refs: #34220
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request Apr 6, 2026
@Renegade334@aduh95
doc: clarify async caveats for events.once()
f829b89
PR-URL: #61572
Refs: #34220
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request Apr 8, 2026
@Renegade334@aduh95
doc: clarify async caveats for events.once()
a810f5c
PR-URL: #61572
Refs: #34220
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito pushed a commit that referenced this pull request May 11, 2026
@Renegade334@marco-ippolito
doc: clarify async caveats for events.once()
9fad6ce
PR-URL: #61572
Refs: #34220
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@trivikrtrivikrtrivikr approved these changes
+1 more reviewer
@antsmartianantsmartianantsmartian approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.eventsIssues and PRs related to the events subsystem / EventEmitter.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

events: timing issue awaiting multiple events emitted in same nextTick

5 participants

@jasnell@antsmartian@lpinca@trivikr@nodejs-github-bot