Skip to content

doc: document the ready event for Http2Stream - #34221

Closed
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:doc-for-http2stream-ready
Closed

doc: document the ready event for Http2Stream#34221
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:doc-for-http2stream-ready

Conversation

@jasnell

@jasnelljasnell commented Jul 6, 2020

Copy link
Copy Markdown
Member

Fixes: #22804

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem. labels Jul 6, 2020
@addaleaxaddaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 7, 2020
@jasnell

jasnell commented Jul 9, 2020

Copy link
Copy Markdown
MemberAuthor

Landed in f98a441

@jasnelljasnell closed this Jul 9, 2020
jasnell added a commit that referenced this pull request Jul 9, 2020
@jasnell
doc: document the ready event for Http2Stream
f98a441
Fixes: #22804
PR-URL: #34221
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2020
@jasnell@MylesBorins
doc: document the ready event for Http2Stream
fadc5f8
Fixes: #22804
PR-URL: #34221
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Jul 14, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Jul 16, 2020
@jasnell@MylesBorins
doc: document the ready event for Http2Stream
9339f9f
Fixes: #22804
PR-URL: #34221
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@jasnell@addaleax
doc: document the ready event for Http2Stream
5ce4935
Fixes: #22804
PR-URL: #34221
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@jasnell@addaleax
doc: document the ready event for Http2Stream
2615e55
Fixes: #22804
PR-URL: #34221
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@codebyterecodebytere mentioned this pull request Sep 28, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes
@lpincalpincalpinca approved these changes
@trivikrtrivikrtrivikr approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.http2Issues or PRs related to the http2 subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Docs missing for http2Stream.id and the 'ready' event

5 participants

@jasnell@addaleax@lpinca@trivikr@nodejs-github-bot