Uh oh!
There was an error while loading. Please reload this page.
[v12.x] http: fix crash for sync write errors during header parsing - #34251
Closed
addaleax wants to merge 3 commits into
Closed
[v12.x] http: fix crash for sync write errors during header parsing#34251addaleax wants to merge 3 commits into
addaleax wants to merge 3 commits into
Conversation
Fix a crash that occurs when `parser.finish()` is called during `parser.execute()`. In this particular case, this happened because a 100 continue response is a place in which `.end()` can be called which can in turn lead to a write error, which is emitted synchronously, thus inside the outer `parser.execute()` call. Resolve that by delaying the `parser.finish()` call until after the `parser.execute()` call is done. This only affects v12.x, because on later versions, errors are not emitted synchronously. Fixes: nodejs#15102
Since the tests only crash on v12.x, this commit adds separate regression tests. Refs: nodejs#15102
nodejs-github-bot
commented
Jul 7, 2020
Collaborator
addaleax
commented
Jul 14, 2020
MemberAuthor
@nodejs/http Can anybody review this? Only the first commit needs reviews, the remainder is just a backport of #34250 |
codebytereforce-pushed
the
v12.x-staging
branch
2 times, most recently
from
July 21, 2020 18:34
b64963e to
3b1d9b3CompareMylesBorins
commented
Aug 18, 2020
Contributor
ping @nodejs/http |
BethGriggs
commented
Aug 18, 2020
Member
Flarna
approved these changes
Aug 18, 2020
lsr0
commented
Sep 20, 2020
Can I ask what is left in the process to get this merged into 12.x, or if there is anything we can do to help? |
addaleaxforce-pushed
the
v12.x-staging
branch
from
September 22, 2020 09:25
be41c83 to
efb5192Compareaddaleax
commented
Sep 22, 2020
MemberAuthor
@lsr0 I don’t think there’s anything missing here, I’ll try to make sure it goes into the next release. |
nodejs-github-bot
commented
Sep 22, 2020
Collaborator
addaleaxforce-pushed
the
v12.x-staging
branch
from
September 22, 2020 16:11
efb5192 to
26f2d97Compareaddaleaxforce-pushed
the
v12.x-staging
branch
from
September 22, 2020 16:27
26f2d97 to
55fe022Comparenodejs-github-bot
commented
Sep 22, 2020
Collaborator
addaleaxforce-pushed
the
v12.x-staging
branch
from
September 22, 2020 17:57
55fe022 to
65b7bf4Comparenodejs-github-bot
commented
Sep 22, 2020
Collaborator
addaleax
commented
Sep 22, 2020
MemberAuthor
Landed in 65b7bf4...867c451 |
addaleax added a commit
that referenced
this pull request
Sep 22, 2020
Fix a crash that occurs when `parser.finish()` is called during `parser.execute()`. In this particular case, this happened because a 100 continue response is a place in which `.end()` can be called which can in turn lead to a write error, which is emitted synchronously, thus inside the outer `parser.execute()` call. Resolve that by delaying the `parser.finish()` call until after the `parser.execute()` call is done. This only affects v12.x, because on later versions, errors are not emitted synchronously. PR-URL: #34251Fixes: #15102Fixes: #34016 Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
http: fix crash for sync write errors during header parsing
Fix a crash that occurs when
parser.finish()is called duringparser.execute(). In this particular case, this happened becausea 100 continue response is a place in which
.end()can be calledwhich can in turn lead to a write error, which is emitted
synchronously, thus inside the outer
parser.execute()call.Resolve that by delaying the
parser.finish()call until afterthe
parser.execute()call is done.This only affects v12.x, because on later versions, errors are not
emitted synchronously.
Fixes: #15102
Fixes: #34016
test: add regression tests for HTTP parser crash
Since the tests only crash on v12.x, this commit adds separate
regression tests.
Refs: #15102
Refs: #34016
[This is #34250, which this PR is blocked on.]
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes