quic: more quic refactorings and cleanups by jasnell · Pull Request #34283 · nodejs/node

jasnell · 2020-07-09T19:25:28Z

Builds on #34262 ... that one needs to land first (the first three commits are from that PR)

quic: replace ipv6Only option with 'udp6-only' type
Since the ipv6Only option was mutually exclusive with
using 'udp6', making it it's own type simplifies things
a bit.

(more will be added)

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

jasnell · 2020-07-13T22:58:05Z

@nodejs/quic ... there's still a lot more to do on this but this PR is already fairly large and complicated so I wanted to get this one in review. There are several major pieces in here:

Movement to a Promises-based API. The QuicEndpoint, QuicSocket, and QuicSession classes have been moved to a Promises-based API for listen(), connect(), close(), etc. The openStream() API will also be come Promise based as well as the close() API on QuicStream. This enables code like:

constsock=createQuicSocket();sock.on('session',(session)=>{session.on('stream',(stream)=>stream.end('hi!'));});awaitsock.listen();

and

constsock=createQuicSocket();constclient=awaitsock.connect();conststream=awaitclient.openStream();stream.end('hello');awaitclient.close();

Improved error handling for event emitter handlers (work in progress). Previously, the error handling was rudimentary and incomplete and did not properly account for async functions used as event handlers. This starts to improve that incrementally but additional changes will come in the next PR round.
Improved QuicSession shutdown timing to match the spec. Previously, shutting down a QuicSession was not properly following the spec in terms of timing. There will be additional refinements made but this is much much closer to what it should be.
Other API cleanups. More will be coming. The next PR will focus largely on refactoring the lifecycle of QuicStream so that we can use the default autoDestroy: true, eliminate things like aborted, and generally just cleanup the implementation.

addaleax · 2020-07-13T23:13:07Z

If we do this, should we update net and dgram to also accept 'udp6-only'? It seems odd that we deviate from the type + ipv6Only option pairing only in this place

Yes, eventually we should, yes. I just don't want to do it in this PR.

nodejs-github-bot · 2020-07-14T00:01:00Z

CI: https://ci.nodejs.org/job/node-test-pull-request/32324/
QUIC CI: https://ci.nodejs.org/job/node-test-commit/39619/

jasnell · 2020-07-14T01:34:49Z

CIs are good

Since the `ipv6Only` option was mutually exclusive with using `'udp6'`, making it it's own type simplifies things a bit.

Doesn't need to be a function

Restricting this to pre-bind keeps things simple

Ensure that the QuicSocket is properly destroyed if the QuicEndpoint is destroyed directly rather than through QuicSocket destroy

PR-URL: #34283 Reviewed-By: Anna Henningsen <anna@addaleax.net>

jasnell · 2020-07-16T00:18:09Z

Landed in 48404a1...89453cf

ruyadorno · 2020-07-22T15:38:48Z

QUIC related, needs to be backported to v14.x 😊

jasnell · 2020-07-22T16:21:22Z

None of the quic related prs should be backported

ruyadorno · 2020-07-22T21:26:06Z

thanks for letting me know @jasnell!

I'm watching nodejs/github-bot#267 and in the meantime will update the issues I touched today to have the correct label 😊

Since the `ipv6Only` option was mutually exclusive with using `'udp6'`, making it it's own type simplifies things a bit. PR-URL: #34283 Reviewed-By: Anna Henningsen <anna@addaleax.net>

PR-URL: #34283 Reviewed-By: Anna Henningsen <anna@addaleax.net>

Doesn't need to be a function PR-URL: #34283 Reviewed-By: Anna Henningsen <anna@addaleax.net>

Restricting this to pre-bind keeps things simple PR-URL: #34283 Reviewed-By: Anna Henningsen <anna@addaleax.net>

PR-URL: #34283 Reviewed-By: Anna Henningsen <anna@addaleax.net>

Ensure that the QuicSocket is properly destroyed if the QuicEndpoint is destroyed directly rather than through QuicSocket destroy PR-URL: #34283 Reviewed-By: Anna Henningsen <anna@addaleax.net>

PR-URL: #34283 Reviewed-By: Anna Henningsen <anna@addaleax.net>

This is the start of a conversion over to a fully Promise-centric API for the QUIC implementation. PR-URL: #34283 Reviewed-By: Anna Henningsen <anna@addaleax.net>

PR-URL: #34283 Reviewed-By: Anna Henningsen <anna@addaleax.net>

QuicClientSession and QuicServerSessions are now always immediately ready for use when they are created, so no more need to track ready state. PR-URL: #34283 Reviewed-By: Anna Henningsen <anna@addaleax.net>

PR-URL: #34283 Reviewed-By: Anna Henningsen <anna@addaleax.net>

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Jul 9, 2020

jasnell force-pushed the quic-cleanups-6 branch 5 times, most recently from 534f1e8 to 5b5deb3Compare July 13, 2020 22:25

jasnell marked this pull request as ready for review July 13, 2020 22:49

jasnell requested a review from a teamJuly 13, 2020 22:49

jasnell force-pushed the quic-cleanups-6 branch from 5b5deb3 to c4337deCompare July 13, 2020 23:16

This comment has been minimized.
Sign in to view

addaleax approved these changes Jul 13, 2020
View reviewed changes

jasnell force-pushed the quic-cleanups-6 branch from 95165d9 to 46983c2Compare July 13, 2020 23:52

jasnell commented Jul 13, 2020
View reviewed changes

Comment threaddoc/api/quic.md Outdated

jasnell force-pushed the quic-cleanups-6 branch from 03887c0 to 644d1e4Compare July 13, 2020 23:57

github-actionsBot mentioned this pull request Jul 14, 2020
CI Relability 2020-07-14 JaneaSystems/nodejs-reliability#37
Open
10 tasks

jasnell added the quic Issues and PRs related to the QUIC implementation / HTTP/3. label Jul 14, 2020

jasnell mentioned this pull request Jul 14, 2020
quic: continued refactoring of quic APIs #34351
Closed
4 tasks

github-actionsBot mentioned this pull request Jul 15, 2020
CI Relability 2020-07-15 JaneaSystems/nodejs-reliability#38
Open
13 tasks

jasnell added 8 commits July 15, 2020 17:15

quic: replace ipv6Only option with 'udp6-only' type
b17ab97
Since the `ipv6Only` option was mutually exclusive with using `'udp6'`, making it it's own type simplifies things a bit.

quic: minor reduction in code duplication
63b79fd

quic: clarifying code comments
cc4674d

quic: use a getter for stream options
99b37e0
Doesn't need to be a function

quic: restrict addEndpoint to before QuicSocket bind
7297f70
Restricting this to pre-bind keeps things simple

quic: fix endpointClose error handling, document
8ffa9e8

quic: fixup kEndpointClose
b3a51d4
Ensure that the QuicSocket is properly destroyed if the QuicEndpoint is destroyed directly rather than through QuicSocket destroy

quic: handle unhandled rejections on QuicSession
fcfa129

jasnell added a commit that referenced this pull request Jul 16, 2020
quic: fixup quic.md
89453cf
PR-URL: #34283 Reviewed-By: Anna Henningsen <anna@addaleax.net>

jasnell closed this Jul 16, 2020

ruyadorno added the backport-requested-v14.x label Jul 22, 2020

ruyadorno added dont-land-on-v12.x and removed backport-requested-v14.x labels Jul 22, 2020

cjihrig pushed a commit that referenced this pull request Jul 23, 2020
quic: minor reduction in code duplication
86597db
PR-URL: #34283 Reviewed-By: Anna Henningsen <anna@addaleax.net>

cjihrig pushed a commit that referenced this pull request Jul 23, 2020
quic: clarifying code comments
67903f6
PR-URL: #34283 Reviewed-By: Anna Henningsen <anna@addaleax.net>

cjihrig pushed a commit that referenced this pull request Jul 23, 2020
quic: use a getter for stream options
ee7e2e5
Doesn't need to be a function PR-URL: #34283 Reviewed-By: Anna Henningsen <anna@addaleax.net>

cjihrig pushed a commit that referenced this pull request Jul 23, 2020
quic: restrict addEndpoint to before QuicSocket bind
b9297f3
Restricting this to pre-bind keeps things simple PR-URL: #34283 Reviewed-By: Anna Henningsen <anna@addaleax.net>

cjihrig pushed a commit that referenced this pull request Jul 23, 2020
quic: fix endpointClose error handling, document
4eb0b3f
PR-URL: #34283 Reviewed-By: Anna Henningsen <anna@addaleax.net>

cjihrig pushed a commit that referenced this pull request Jul 23, 2020
quic: handle unhandled rejections on QuicSession
59976b6
PR-URL: #34283 Reviewed-By: Anna Henningsen <anna@addaleax.net>

cjihrig pushed a commit that referenced this pull request Jul 23, 2020
quic: implement QuicEndpoint Promise API
3a101ef
This is the start of a conversion over to a fully Promise-centric API for the QUIC implementation. PR-URL: #34283 Reviewed-By: Anna Henningsen <anna@addaleax.net>

cjihrig pushed a commit that referenced this pull request Jul 23, 2020
quic: implement QuicSocket Promise API, part 1
766320b
PR-URL: #34283 Reviewed-By: Anna Henningsen <anna@addaleax.net>

cjihrig pushed a commit that referenced this pull request Jul 23, 2020
quic: implement QuicSocket Promise API, part 2
b471188
PR-URL: #34283 Reviewed-By: Anna Henningsen <anna@addaleax.net>

cjihrig pushed a commit that referenced this pull request Jul 23, 2020
quic: use promisified dns lookup
ddcafa3
PR-URL: #34283 Reviewed-By: Anna Henningsen <anna@addaleax.net>

cjihrig pushed a commit that referenced this pull request Jul 23, 2020
quic: cleanup QuicClientSession constructor
747ae45
PR-URL: #34283 Reviewed-By: Anna Henningsen <anna@addaleax.net>

cjihrig pushed a commit that referenced this pull request Jul 23, 2020
quic: implement QuicSession close as promise
d2917a5
PR-URL: #34283 Reviewed-By: Anna Henningsen <anna@addaleax.net>

Navigation Menu

Uh oh!

Uh oh!

quic: more quic refactorings and cleanups - #34283

quic: more quic refactorings and cleanups#34283
jasnell wants to merge 18 commits into
nodejs:masterfrom
jasnell:quic-cleanups-6

jasnell commented Jul 9, 2020•
edited
Loading

Uh oh!

jasnell commented Jul 13, 2020

Uh oh!

This comment has been minimized.

addaleaxJul 13, 2020

Uh oh!

jasnellJul 13, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented Jul 14, 2020•
edited by jasnell
Loading

Uh oh!

jasnell commented Jul 14, 2020

Uh oh!

jasnell commented Jul 16, 2020

Uh oh!

ruyadorno commented Jul 22, 2020

Uh oh!

jasnell commented Jul 22, 2020

Uh oh!

ruyadorno commented Jul 22, 2020•
edited
Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

jasnell commented Jul 9, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

jasnell commented Jul 13, 2020

Uh oh!

This comment has been minimized.

addaleaxJul 13, 2020

Choose a reason for hiding this comment

Uh oh!

jasnellJul 13, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented Jul 14, 2020• edited by jasnell Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jasnell commented Jul 14, 2020

Uh oh!

jasnell commented Jul 16, 2020

Uh oh!

ruyadorno commented Jul 22, 2020

Uh oh!

jasnell commented Jul 22, 2020

Uh oh!

ruyadorno commented Jul 22, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jasnell commented Jul 9, 2020•
edited
Loading

nodejs-github-bot commented Jul 14, 2020•
edited by jasnell
Loading

ruyadorno commented Jul 22, 2020•
edited
Loading