Uh oh!
There was an error while loading. Please reload this page.
test: repl-persistent-history is no longer flaky - #3437
Merged
Conversation
evanlucas
commented
Oct 19, 2015
Contributor
LGTM |
Fishrock123
commented
Oct 19, 2015
ContributorAuthor
CI on |
jasnell
commented
Oct 19, 2015
Member
Potentially unrelated failures in CI need to be verified. Otherwise LGTM. |
Fishrock123
commented
Oct 19, 2015
ContributorAuthor
Windows is all net-related stuff, mostly PPC: Seem unrelated? Another run: https://ci.nodejs.org/job/node-test-pull-request/535/ |
jbergstroem
commented
Oct 20, 2015
Member
@Fishrock123 unrelated; #3390 |
jbergstroem
commented
Oct 20, 2015
Member
LGTM |
Fishrock123force-pushed
the
no-flaky-repl-history
branch
from
October 20, 2015 14:43
e1d896d to
0c38ce4CompareThe race conditions were fixed in 286ef1d PR-URL: nodejs#3437 Reviewed By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Fishrock123force-pushed
the
no-flaky-repl-history
branch
from
October 20, 2015 14:45
0c38ce4 to
5923deeCompareFishrock123
commented
Oct 20, 2015
ContributorAuthor
Thanks, landed in 5923dee I should probably look at having this run in |
MylesBorins
commented
Oct 23, 2015
Contributor
this should be considered for LTS /cc @jasnell |
jasnell
commented
Oct 26, 2015
Member
Landed in v4.x-staging in 3d1f57d |
Fishrock123
commented
Oct 26, 2015
ContributorAuthor
@jasnell you landed the related fix(es) right? |
jasnell
commented
Oct 26, 2015
Member
@Fishrock123 .. thanks for the reminder... #2356 (comment) |
This was referenced Nov 29, 2023
This was referenced Nov 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The race conditions were fixed in
286ef1d
R=@evanlucas?